Skip to content

Bound the stripe statistics index in startNextStripe and getStripeStatistics #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PedroTadim merged 2 commits into from
Oct 8, 2026
Merged

Bound the stripe statistics index in startNextStripe and getStripeStatistics #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ef93dc
Bound the stripe statistics index in startNextStripe and getStripeSta…
groeneai Oct 6, 2026
2c69dbd
Throw InvalidArgument instead of std::logic_error for a bad stripe index
groeneai Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions c++/src/Reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,6 +887,15 @@ namespace orc {
if (contents_->metadata == nullptr) {
throw std::logic_error("No stripe statistics in file");
}
if (contents_->metadata->stripe_stats_size() != footer_->stripes_size()) {
std::stringstream msg;
msg << "Malformed metadata: the file has " << footer_->stripes_size() << " stripes but "
<< contents_->metadata->stripe_stats_size() << " stripe statistics";
throw ParseError(msg.str());
}
if (stripeIndex >= numberOfStripes_) {
throw InvalidArgument("stripe index out of range");
}

proto::StripeInformation currentStripeInfo = footer_->stripes(static_cast<int>(stripeIndex));
proto::StripeFooter currentStripeFooter = getStripeFooter(currentStripeInfo, *contents_.get());
Expand Down Expand Up @@ -1300,8 +1309,9 @@ namespace orc {
processingStripe_ = currentStripe_;

bool isStripeNeeded = true;
// If PPD enabled and stripe stats existed, evaulate it first
if (sargsApplier_ && contents_->metadata) {
// If PPD enabled and the stripe stats match the stripes one to one, evaluate them first
if (sargsApplier_ && contents_->metadata &&
contents_->metadata->stripe_stats_size() == footer_->stripes_size()) {
const auto& currentStripeStats =
contents_->metadata->stripe_stats(static_cast<int>(currentStripe_));
// skip this stripe after stats fail to satisfy sargs
Expand Down
Loading