Remove the LogFactory class from the python module #4034
+191
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrwahl2
reviewed
Jan 27, 2026
This is the first step in getting rid of the LogFactory class entirely. First, we'll just duplicate all its functions as module-level functions and then modify those in the class to use the same global variables. Ref T680
It can just access the module-level functions from the logging module instead. Ref T680
Nothing is using it anymore, and it wasn't even an especially good factory class. Instead we can just use global variables and module-level functions to do the same thing. Ref T680
clumens
force-pushed
the
no-logger-factory
branch
from
c8741eb to
14749d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.