mctp-client: add cci message type code - #168
Merged
Merged
Conversation
jk-ozlabs
requested changes
Aug 7, 2026
jk-ozlabs
left a comment
jk-ozlabs
left a comment
Member
There was a problem hiding this comment.
Change itself looks okay, just a comment on the chosen name here.
However, the commit message just needs a little work. The wording is a little off, and no need for the section break there, nor that Testing line (we assume that you have tested this before submission).
Maybe just:
Add type code 8 for CXL Type 3 Device Component Command Interface,
as defined by DSP0239 1.9.0 and later.For example:
$ mctp-client eid 10 type cxl-cci data 00 00 00 00 03 00 00 00 00 00 cd ab 01 00 00 00 03 08 00 00 00 00 00 00 2B 01 AD 9C A4 8A D2 16
Add type code 8 for CXL Type 3 Device Component Command Interface, as defined by DSP0239 1.9.0 and later. For example: ``` $ mctp-client eid 9 type cxl-cci data 00 00 00 00 03 00 00 00 00 00 cd ab 01 00 00 00 03 08 00 00 00 00 00 00 E5 52 F9 1E 50 21 D3 16 ``` Signed-off-by: Leo Yang <Leo-Yang@quantatw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Specification DSP0239 1.12.0
Add type code 8 for use with the CXL Type 3 Device Component Command Interface over MCTP.
Testing
cci commands