London | 26-SDC-Mar | beko | Sprint 1 | analyse and refactor functions#173
Open
Abubakar-Meigag wants to merge 1 commit into
Open
London | 26-SDC-Mar | beko | Sprint 1 | analyse and refactor functions#173Abubakar-Meigag wants to merge 1 commit into
Abubakar-Meigag wants to merge 1 commit into
Conversation
Abubakar-Meigag
added
📅 Sprint 1
cjyuan
reviewed
Jun 24, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Complexity analysis and code are good. Well done.
Comment on lines
+12
to
+17
| export const findCommonItems = (firstArray, secondArray) => { | ||
| let second = new Set(secondArray) | ||
| return [ ...new Set(firstArray.filter((item) => second.has(item))) ] | ||
| } | ||
| console.log(findCommonItems([1, 2, 2, 3], [4, 3, 2])) | ||
|
|
There was a problem hiding this comment.
Note: A set data structure typically supports set operations such as union, intersect, etc. You could also explore using these methods to simplify your solution.
Comment on lines
+15
to
+20
| for(let i=0; i < numbers.length; i++){ | ||
| let num = target - numbers[i] | ||
| if(checkPoint.has(num)){ | ||
| return true | ||
| }else { | ||
| checkPoint.add(numbers[i]) |
There was a problem hiding this comment.
The formatting of the code is not quite consistent.
More importantly, have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode?
See https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md for more info.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Complete analyse and refactor functions sprint 1 for Complexity