Skip to content

NW | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | implement_linked_list#174

Open
ZabihollahNamazi wants to merge 1 commit into
CodeYourFuture:mainfrom
ZabihollahNamazi:sprint-2
Open

NW | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | implement_linked_list#174
ZabihollahNamazi wants to merge 1 commit into
CodeYourFuture:mainfrom
ZabihollahNamazi:sprint-2

Conversation

@ZabihollahNamazi

@ZabihollahNamazi ZabihollahNamazi commented Jun 24, 2026

Copy link
Copy Markdown
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Hi! Could you please check my code?
The code correctly handles inserting nodes, deleting nodes, and traversing the list while maintaining the proper pointers.
All tests are passing perfectly. Thank you!

@ZabihollahNamazi ZabihollahNamazi added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Complexity The name of the module. labels Jun 24, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Comment on lines +1 to +5
class Node:
def __init__(self, value):
self.value = value
self.previous = None
self.next = None

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest exploring the use of __slots__ to reduce memory usage?

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 24, 2026
@cjyuan

cjyuan commented Jun 24, 2026

Copy link
Copy Markdown

This is not a proper content of a "Changelist" section. Could you update your other PR description as well?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Complexity The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants