NW | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | improve with caches#177
Open
ZabihollahNamazi wants to merge 2 commits into
Open
NW | 26-SDC-Mar | Zabihollah Namazi | Sprint 2 | improve with caches#177ZabihollahNamazi wants to merge 2 commits into
ZabihollahNamazi wants to merge 2 commits into
Conversation
ZabihollahNamazi
added
Needs Review
cjyuan
reviewed
Jun 26, 2026
Comment on lines
+8
to
+17
| prev2 = 0 # fibonacci(0) | ||
| prev1 = 1 # fibonacci(1) | ||
|
|
||
| # Calculate upward to n | ||
| for _ in range(2, n + 1): | ||
| current = prev1 + prev2 | ||
| prev2 = prev1 | ||
| prev1 = current | ||
|
|
||
| return prev1 No newline at end of file |
There was a problem hiding this comment.
Replacing the recursive approach with an iterative one defeats the purpose of this exercise, which is to improve the performance of a recursive function using caching. Could you update the code while keeping the original recursive implementation?
Comment on lines
+2
to
+12
| coins = [1, 2, 5, 10, 20, 50, 100, 200] | ||
|
|
||
| dp = [0] * (total + 1) | ||
|
|
||
| dp[0] = 1 | ||
|
|
||
| for coin in coins: | ||
| for i in range(coin, total + 1): | ||
| dp[i] += dp[i - coin] | ||
|
|
||
| return dp[total] No newline at end of file |
There was a problem hiding this comment.
Good job in finding out a faster approach to find the solution.
Could you also include an implementation that uses cache to speed up the original recursive implementation?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Could you please check my code?
I changed the Fibonacci and Making Change code. The old code was too slow and crashed with big numbers. I fixed it by using caching and loops so the code runs fast and passes all the big tests instantly.
Thank you!