Glasgow | Sheetal Kharab | Module-Complexity | Sprint 1 | Analyse and refactor#32
Glasgow | Sheetal Kharab | Module-Complexity | Sprint 1 | Analyse and refactor#32sheetalkharab wants to merge 5 commits into
Conversation
sheetalkharab
added
the
Needs Review
| * Time Complexity: | ||
| * Space Complexity: | ||
| * Optimal Time Complexity: | ||
| * Time Complexity:O(2n) originall have this as using 2 separate loops |
There was a problem hiding this comment.
O(n) is the same as O(2n). We ignore the constant multiplier in big-O notation.
There was a problem hiding this comment.
Thank you for the clarification.
I’ve updated the time complexity to O(n), since constant multipliers are ignored in Big-O notation.
| * Time Complexity: | ||
| * Space Complexity: | ||
| * Optimal Time Complexity: | ||
| * Time Complexity:O(n+m) it build set and loop through arrays once |
There was a problem hiding this comment.
What's the complexity of Array.include()?
.filter() suggests a "loop", and inside the loop .includes() is called repeatedly.
There was a problem hiding this comment.
@cjyuan Thank you for the clarification.
The previous implementation using .includes() would have been O(n × m).
After refactoring to use a Set, the time complexity is now O(n + m), and space complexity is O(m).
| * Optimal Time Complexity: | ||
| * Time Complexity:O(n+m) it build set and loop through arrays once | ||
| * Space Complexity: store second array in set | ||
| * Optimal Time Complexity:O(m+n) |
cjyuan
added
Reviewed
sheetalkharab
added
the
Needs Review
|
Code is good. Thanks for all responses. |
cjyuan
added
Complete
|
Closing PR because the SDC run has finished. Feel free to re-open if you're still working on it. |
3 participants
Learners, PR Template
Self checklist
Changelist
refactor code
Questions
No