Skip to content

Glasgow | 25-ITP-SEP | Alaa Tagi | Sprint 2 | Book/Library #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Alaa-Tagi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Glasgow | 25-ITP-SEP | Alaa Tagi | Sprint 2 | Book/Library #346

Alaa-Tagi wants to merge 3 commits into from
+104 −141

Conversation

@Alaa-Tagi
Copy link

@Alaa-Tagi Alaa-Tagi commented Dec 7, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have made some changes in script.js file to meet the rquirements.

Questions

No question.

@Alaa-Tagi Alaa-Tagi added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Dec 7, 2025
cjyuan
cjyuan reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 8, 2025
@Alaa-Tagi
Copy link
Author

Alaa-Tagi commented Dec 8, 2025

i fixed HTML,JS and CSS files to match all requirements in this project.

@Alaa-Tagi Alaa-Tagi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 8, 2025
cjyuan
cjyuan reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is greatly improved.

Input validation part can still use some improvement.

debugging/book-library/script.js Outdated
Comment on lines 30 to 33
if (Number.isNaN(pages) || pages <= 0) {
alert("Page count must be a positive number.");
return;
}
Copy link
Contributor

@cjyuan cjyuan Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some invalid "number of pages" can still pass the check on line 30.

debugging/book-library/script.js Outdated
Comment on lines 62 to 66
row.insertCell().textContent = book.title;
row.insertCell().textContent = book.author;
row.insertCell().textContent = book.pages;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
const readCell = row.insertCell();
Copy link
Contributor

@cjyuan cjyuan Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of the pros and cons of these two approaches for creating cells within a row?

  • Keeping all the cell creation code in one location, like what the original code does.
  • Scattering the cell creation code across different locations, like what you did.

Copy link
Author

@Alaa-Tagi Alaa-Tagi Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Keeping all cell creation code in one place make the structure easier to read and maintain, while scattering the code can make each part easier to manage but can also make the table setup less clear.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 9, 2025
@Alaa-Tagi Alaa-Tagi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 9, 2025
cjyuan
cjyuan reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 9, 2025
@Alaa-Tagi Alaa-Tagi mentioned this pull request Dec 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Flows The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alaa-Tagi @cjyuan