Manchester | 25-ITP-Sep | Mahtem T. Mengstu | Sprint 2 | Book_library

.vscode/launch.json

@@ -0,0 +1,15 @@
+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "type": "chrome",
+            "request": "launch",
+            "name": "Launch Chrome against localhost",
+            "url": "http://localhost:8080",
+            "webRoot": "${workspaceFolder}"
+        }
+    ]
+}

debugging/book-library/index.html

@@ -28,69 +28,35 @@ <h1>Library</h1>
     </button>
 
     <div id="demo" class="collapse">
-      <div class="form-group">
-        <label for="title">Title:</label>
-        <input
-          type="title"
-          class="form-control"
-          id="title"
-          name="title"
-          required
-        />
-        <label for="author">Author: </label>
-        <input
-          type="author"
-          class="form-control"
-          id="author"
-          name="author"
-          required
-        />
-        <label for="pages">Pages:</label>
-        <input
-          type="number"
-          class="form-control"
-          id="pages"
-          name="pages"
-          required
-        />
-        <label class="form-check-label">
-          <input
-            type="checkbox"
-            class="form-check-input"
-            id="check"
-            value=""
-          />Read
-        </label>
-        <input
-          type="submit"
-          value="Submit"
-          class="btn btn-primary"
-          onclick="submit();"
-        />
-      </div>
-    </div>
+  <div class="form-group">
+    <label for="title">Title:</label>
+    <input type="text" class="form-control" id="title" required />
+
+    <label for="author">Author: </label>
+    <input type="text" class="form-control" id="author" required />
+
+    <label for="pages">Pages:</label>
+    <input type="number" class="form-control" id="pages" required />
+
+    <label class="form-check-label">
+      <input type="checkbox" class="form-check-input" id="check" />Read
+    </label>
+
+    <input type="button" value="Submit" class="btn btn-primary" onclick="submit();" />
+  </div>
+</div>
 
-    <table class="table" id="display">
-      <thead class="thead-dark">
-        <tr>
-          <th>Title</th>
-          <th>Author</th>
-          <th>Number of Pages</th>
-          <th>Read</th>
-          <th></th>
-        </tr>
-      </thead>
-      <tbody>
-        <tr>
-          <td></td>
-          <td></td>
-          <td></td>
-          <td></td>
-          <td></td>
-        </tr>
-      </tbody>
-    </table>
+<table class="table" id="display">
+  <thead class="thead-dark">
+    <tr>
+      <th>Title</th>
+      <th>Author</th>
+      <th>Number of Pages</th>
+      <th>Read</th>
+      <th></th>
+    </tr>
+  </thead>
+  <tbody></tbody> 
+</table>
 
-    <script src="script.js"></script>
-  </body>
-</html>
+<script src="script.js"></script>

debugging/book-library/readme.md

@@ -12,12 +12,20 @@ My website should be able to:
 
 ## Bugs to be fixed
 
-1. Website loads but doesn't show any books
-2. Error in console when you try to add a book
-3. It uses the title name as the author name
-4. Delete button is broken
+1. Website loads but doesn't show any books 
+    |Ans: fixed to show books
+2. Error in console when you try to add a book 
+    Ans: We can add now.
+3. It uses the title name as the author name 
+    Ans: has been fixed
+4. Delete button is broken 
+    ANs: has been functional 
 5. When I add a book that I say I've read - it saves the wrong answer
+   Ans: it is working normal
 
 I think there are other some other small bugs in my code...but I'm lazy so I can't fix them all.
+ -- Page number used to accept 0 or even negative numbers. Now it only accept >=1 
 
 I wish somebody would help me!
+
+I think I have tried something. 

debugging/book-library/script.js

@@ -1,19 +1,19 @@
 let myLibrary = [];
 
-window.addEventListener("load", function (e) {
+window.addEventListener("load", function () {
   populateStorage();
-  render();
 });
 
 function populateStorage() {
-  if (myLibrary.length == 0) {
-    let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
+  if (myLibrary.length === 0) {
+    let book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true);
     let book2 = new Book(
       "The Old Man and the Sea",
       "Ernest Hemingway",
-      "127",
+      127,
       true
     );
+
     myLibrary.push(book1);
     myLibrary.push(book2);
     render();
@@ -25,22 +25,38 @@ const author = document.getElementById("author");
 const pages = document.getElementById("pages");
 const check = document.getElementById("check");
 
-//check the right input from forms and if its ok -> add the new book (object in array)
-//via Book function and start render function
 function submit() {
-  if (
-    title.value == null ||
-    title.value == "" ||
-    pages.value == null ||
-    pages.value == ""
-  ) {
+  // Step 1: store preprocessed raw input in variables
+  const titleVal = title.value.trim();
+  const authorVal = author.value.trim();
+  const pagesVal = pages.value.trim();
+  const readVal = check.checked;
+
+  // Step 2: validate values
+  if (!titleVal || !authorVal || !pagesVal) {
     alert("Please fill all fields!");
-    return false;
-  } else {
-    let book = new Book(title.value, title.value, pages.value, check.checked);
-    library.push(book);
-    render();
+    return;
+  }
+
+  // Pages validation (must be integer >= 1)
+  const pagesNum = Number(pagesVal);
+  if (!Number.isInteger(pagesNum) || pagesNum < 1) {
+    alert("Pages must be an integer greater than or equal to 1!");
+    return;
   }
+
+  // Step 3: create Book using validated variables
+  const book = new Book(titleVal, authorVal, pagesNum, readVal);
+
+  myLibrary.push(book);
+
+  // Clear inputs
+  title.value = "";
+  author.value = "";
+  pages.value = "";
+  check.checked = false;
+
+  render();
 }
 
 function Book(title, author, pages, check) {
@@ -53,51 +69,54 @@ function Book(title, author, pages, check) {
 function render() {
   let table = document.getElementById("display");
   let rowsNumber = table.rows.length;
-  //delete old table
-  for (let n = rowsNumber - 1; n > 0; n-- {
+
+  // Delete old rows (keep header)
+  for (let n = rowsNumber - 1; n > 0; n--) {
     table.deleteRow(n);
   }
-  //insert updated row and cells
-  let length = myLibrary.length;
-  for (let i = 0; i < length; i++) {
+
+  // Insert updated rows
+  for (let i = 0; i < myLibrary.length; i++) {
     let row = table.insertRow(1);
+
     let titleCell = row.insertCell(0);
     let authorCell = row.insertCell(1);
     let pagesCell = row.insertCell(2);
     let wasReadCell = row.insertCell(3);
     let deleteCell = row.insertCell(4);
-    titleCell.innerHTML = myLibrary[i].title;
-    authorCell.innerHTML = myLibrary[i].author;
-    pagesCell.innerHTML = myLibrary[i].pages;
 
-    //add and wait for action for read/unread button
+    titleCell.textContent = myLibrary[i].title;
+    authorCell.textContent = myLibrary[i].author;
+    pagesCell.textContent = myLibrary[i].pages;
+
+    // Read / unread button
     let changeBut = document.createElement("button");
-    changeBut.id = i;
+    changeBut.id = "read-btn-" + i;
     changeBut.className = "btn btn-success";
-    wasReadCell.appendChild(changeBut);
-    let readStatus = "";
-    if (myLibrary[i].check == false) {
-      readStatus = "Yes";
-    } else {
-      readStatus = "No";
-    }
-    changeBut.innerText = readStatus;
+    changeBut.textContent = myLibrary[i].check ? "Yes" : "No";
 
     changeBut.addEventListener("click", function () {
       myLibrary[i].check = !myLibrary[i].check;
       render();
     });
 
-    //add delete button to every row and render again
-    let delButton = document.createElement("button");
-    delBut.id = i + 5;
-    deleteCell.appendChild(delBut);
+    wasReadCell.appendChild(changeBut);
+
+    // Delete button
+    let delBut = document.createElement("button");
+    delBut.id = "del-btn-" + i;
     delBut.className = "btn btn-warning";
-    delBut.innerHTML = "Delete";
-    delBut.addEventListener("clicks", function () {
+    delBut.textContent = "Delete";
+
+    delBut.addEventListener("click", function () {
       alert(`You've deleted title: ${myLibrary[i].title}`);
       myLibrary.splice(i, 1);
       render();
     });
+
+    deleteCell.appendChild(delBut);
   }
 }
+
+
+// Book Library script updated.