Skip to content

London | 26-ITP-Sep | Mandip Sanger | Sprint 2 | Book Library - #569

Open
mandipsanger wants to merge 21 commits into
CodeYourFuture:mainfrom
mandipsanger:book-library
Open

London | 26-ITP-Sep | Mandip Sanger | Sprint 2 | Book Library#569
mandipsanger wants to merge 21 commits into
CodeYourFuture:mainfrom
mandipsanger:book-library

Conversation

@mandipsanger

@mandipsanger mandipsanger commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Self cheklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1122

##Changelist
Sprint 2 Data flows book library

@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger changed the title London | 26-ITP-May | Mandip Sanger | Sprint 3 | Book library London | 26-ITP-May | Mandip Sanger | Sprint 2 | Book library Aug 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2026
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2026
cjyuan
cjyuan reviewed Aug 20, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Aug 20, 2026
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 21, 2026
@mandipsanger mandipsanger changed the title London | 26-ITP-May | Mandip Sanger | Sprint 2 | Book library London | 26-ITP-May | Mandip Sanger | Sprint 3 | Book library Aug 21, 2026
@mandipsanger mandipsanger changed the title London | 26-ITP-May | Mandip Sanger | Sprint 3 | Book library London | 26-ITP-May | Mandip Sanger | Sprint 2 | Book library Aug 21, 2026
@mandipsanger

mandipsanger commented Aug 21, 2026

Copy link
Copy Markdown
Author

My Program is working now but failing checks Validate PR Metadata workflow run.

@mandipsanger mandipsanger changed the title London | 26-ITP-May | Mandip Sanger | Sprint 2 | Book library London | 26-ITP-May | Mandip Sanger | Sprint 2 | Book-library Aug 21, 2026
@mandipsanger mandipsanger changed the title London | 26-ITP-May | Mandip Sanger | Sprint 2 | Book-library London | 26-ITP-May | Mandip Sanger | Sprint 2 | Book Library Aug 21, 2026
@mandipsanger

mandipsanger commented Aug 21, 2026

Copy link
Copy Markdown
Author

its showing Validate PR Metadata
2s
Run args=("/tmp/pr-metadata-validator")

thread 'main' (2352) panicked at src/bin/pr-metadata-validator.rs:74:6:
Failed to validate PR: UserFacing("Failed to parse issue #571 - no submit label.\n\nIf this issue was made my a curriculum team member it should be given a sprint label.\nIf this issue was created by a trainee for step submission, it should probably be closed (and they should create the issue in their fork).")
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Error: Process completed with exit code 101.
do you have any idea

cjyuan
cjyuan reviewed Aug 21, 2026
View reviewed changes
Comment thread debugging/book-library/index.html Outdated
Comment thread debugging/book-library/index.html Outdated
Comment thread debugging/book-library/index.html Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 21, 2026
@mandipsanger mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 21, 2026
cjyuan
cjyuan reviewed Sep 18, 2026
View reviewed changes
Comment thread debugging/book-library/script.js
Comment thread debugging/book-library/index.html Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Complete Volunteer to add when work is complete and all review comments have been addressed. labels Sep 18, 2026
@mandipsanger mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@mandipsanger mandipsanger added the NotCoursework A PR that edits material in the module. Needs review by the curriculum team. label Sep 18, 2026
cjyuan
cjyuan reviewed Sep 19, 2026
View reviewed changes
Comment thread debugging/exampleEJS/script .js

@cjyuan cjyuan Sep 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this file is not part of the book-library exercise, can you remove this file from this PR? Otherwise the Validation bot will keep complaining.

@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

NotCoursework A PR that edits material in the module. Needs review by the curriculum team. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mandipsanger @cjyuan