London | 26-ITP-Jan | Oussama Mouggal | Sprint 3 | Alarm clock#1062
Open
Oussama-Mouggal wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Oussama Mouggal | Sprint 3 | Alarm clock#1062Oussama-Mouggal wants to merge 2 commits intoCodeYourFuture:mainfrom
Oussama-Mouggal wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
cjyuan
reviewed
Mar 30, 2026
Contributor
There was a problem hiding this comment.
(1) Currently when starting a new countdown, the application does not always return to a clean initial state, which can lead to inconsistent behaviour between runs.
Consider introducing a dedicated reset function to return the app to a clean initial state to help ensure consistency.
Note: a user may not click the "Stop" button first before starting a new count down.
(2) When input is 1, the alarm is played one second later -- an expected behavior.
However, when input is 0, the alarm is also played one second later (instead of being played immediately).
Can you make the app's behaviour more consistent?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I changed the title and added the alarm clock logic to the file as requested.