Skip to content

London | 26-ITP-Jan | Oussama Mouggal | Sprint 3 | Alarm clock#1062

Open
Oussama-Mouggal wants to merge 2 commits intoCodeYourFuture:mainfrom
Oussama-Mouggal:Sprint-3-/-Alarm-clock
Open

London | 26-ITP-Jan | Oussama Mouggal | Sprint 3 | Alarm clock#1062
Oussama-Mouggal wants to merge 2 commits intoCodeYourFuture:mainfrom
Oussama-Mouggal:Sprint-3-/-Alarm-clock

Conversation

@Oussama-Mouggal
Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I changed the title and added the alarm clock logic to the file as requested.

@Oussama-Mouggal Oussama-Mouggal added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 22, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1) Currently when starting a new countdown, the application does not always return to a clean initial state, which can lead to inconsistent behaviour between runs.

Consider introducing a dedicated reset function to return the app to a clean initial state to help ensure consistency.

Note: a user may not click the "Stop" button first before starting a new count down.


(2) When input is 1, the alarm is played one second later -- an expected behavior.
However, when input is 0, the alarm is also played one second later (instead of being played immediately).
Can you make the app's behaviour more consistent?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants