Skip to content

Manchester | 26-ITP-May | John Robinson | Sprint 1 | Form Controls#1433

Open
JohnRob-jnr wants to merge 2 commits into
CodeYourFuture:mainfrom
JohnRob-jnr:main
Open

Manchester | 26-ITP-May | John Robinson | Sprint 1 | Form Controls#1433
JohnRob-jnr wants to merge 2 commits into
CodeYourFuture:mainfrom
JohnRob-jnr:main

Conversation

@JohnRob-jnr

@JohnRob-jnr JohnRob-jnr commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I had an issue with my previous form control file but have made the changes & resubmitted

a94f1b6

@Luro91

@netlify

netlify Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 4daf33e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a29d375bb599a0008a69525
😎 Deploy Preview https://deploy-preview-1433--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@JohnRob-jnr JohnRob-jnr added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Core This is a core task and should be completed by all trainees labels Jun 8, 2026
@cjyuan

cjyuan commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Since this PR is a continuation of a previous PR, it's generally recommended to:

  • Include a link to the previous PR in the description to provide additional context and make it easier to reference earlier discussions.
  • Request a review from the reviewer of the previous PR so they're aware of the new PR and can easily continue reviewing the changes.

@JohnRob-jnr JohnRob-jnr added Module-Onboarding The name of the module. and removed Core This is a core task and should be completed by all trainees labels Jun 9, 2026
@JohnRob-jnr JohnRob-jnr marked this pull request as draft June 9, 2026 17:45
@JohnRob-jnr

JohnRob-jnr commented Jun 9, 2026

Copy link
Copy Markdown
Author

Sorry about that, I have added the link but I am unsure how to add @Luro91 to request as the reviewer - there is no button in the 'Reviewers' option

@JohnRob-jnr JohnRob-jnr marked this pull request as ready for review June 9, 2026 17:48
@cjyuan

cjyuan commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Tagging a GitHub user in comments will usually get them notified, which you just did. Let's give them some time to respond.

cjyuan
cjyuan reviewed Jun 10, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your have addressed most comments left by @Luro91 in #1301

The code format could still use some improvement.

Comment thread Form-Controls/index.html Outdated
Comment on lines 46 to 49
</select>
</div>
</form>
</main>

@cjyuan cjyuan Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is slightly off.

Consider enabling VS Code's "Format on Save" option or to use its "Format Document" command to keep your code consistently formatted.

@JohnRob-jnr JohnRob-jnr Jun 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have indented the HTML code, Thanks

Comment thread Form-Controls/index.html Outdated
Comment on lines +39 to +42
<select id="size" name="Size">
<option value="XS">XSmall</option>
<option value="S">Small</option>
<option value="M">Medium</option>

@cjyuan cjyuan Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a way to configure a <select> element so that no option is selected by default, allowing the user to make an explicit choice.

@JohnRob-jnr JohnRob-jnr Jun 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, thats great & have added that

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 10, 2026
@JohnRob-jnr JohnRob-jnr added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 10, 2026
@cjyuan

cjyuan commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Changes look good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 10, 2026
@JohnRob-jnr JohnRob-jnr mentioned this pull request Jun 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JohnRob-jnr @cjyuan