Skip to content

London | 26-ITP-May | Mandip Sanger | Sprint 2 | Wireframe #1441

Open
mandipsanger wants to merge 13 commits into
CodeYourFuture:mainfrom
mandipsanger:Wireframe
Open

London | 26-ITP-May | Mandip Sanger | Sprint 2 | Wireframe #1441
mandipsanger wants to merge 13 commits into
CodeYourFuture:mainfrom
mandipsanger:Wireframe

Conversation

@mandipsanger

@mandipsanger mandipsanger commented Jun 10, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have finished my Wireframe task for sprint 2.

@netlify

netlify Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 4ce5321
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2983cef3e0500008367ea7
😎 Deploy Preview https://deploy-preview-1441--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jun 10, 2026
cjyuan
cjyuan reviewed Jun 10, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  • To better match the wireframe layout, can you

    • Center the page title and the text beneath it
    • Center the footer content (and ensure the footer content and the article text content won't overlap)

  • Code is not yet properly indented or formatted.

    Consider following this guide to enable VS Code's "Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.

Comment thread Wireframe/index.html Outdated
</header>
<main>
<article>
<img src="https://public-images.interaction-design.org/literature/articles/materials/ElementsofaWireframe.png" width="300" height="200" alt="Wireframe" />

@cjyuan cjyuan Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • A better practice is to set the image dimension in CSS.

  • Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images
    fail to load, giving users essential context about the content or function of the image.

Can you give a more descriptive alt value to all images?

@mandipsanger mandipsanger Jun 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much I think I have solved all the issues.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 10, 2026
@mandipsanger mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 10, 2026
@cjyuan

cjyuan commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Changes look good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 10, 2026
@mandipsanger mandipsanger mentioned this pull request Jun 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 🏕 Priority Mandatory This work is expected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mandipsanger @cjyuan