Birmingham | 26-ITP-Jan | Tasleem Adedokun | Sprint 2 | coursework#1082
Open
tasleemadedokun wants to merge 11 commits intoCodeYourFuture:mainfrom
Open
Birmingham | 26-ITP-Jan | Tasleem Adedokun | Sprint 2 | coursework#1082tasleemadedokun wants to merge 11 commits intoCodeYourFuture:mainfrom
tasleemadedokun wants to merge 11 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
tasleemadedokun
added
📅 Sprint 2
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
tasleemadedokun
changed the title
This comment has been minimized.
This comment has been minimized.
tasleemadedokun
changed the title
tasleemadedokun
added
the
Needs Review
netEmmanuel
reviewed
Mar 6, 2026
|
|
||
|
|
||
| function toPounds(penceString) { | ||
| const penceStringWithoutTrailingP = penceString.substring( |
There was a problem hiding this comment.
Minor detail, for code readability. Keep your const declaration on the same line like this
const penceStringWithoutTrailingP = penceString.substring(0,penceString.length - 1);
Author
There was a problem hiding this comment.
Minor detail, for code readability. Keep your const declaration on the same line like this
const penceStringWithoutTrailingP = penceString.substring(0,penceString.length - 1);
Thank you very much. noted with thanks
netEmmanuel
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Brief Explanation;
During this course work I was able to interprete some code, fix some errors and ensured i made commit changes bit by bit.