Skip to content

London|26-ITP-January|Alexandru Pocovnicu|Sprint 1|Coursework #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alexandru-pocovnicu wants to merge 19 commits into
base: main
Choose a base branch
from
Open

London|26-ITP-January|Alexandru Pocovnicu|Sprint 1|Coursework #908

alexandru-pocovnicu wants to merge 19 commits into from

Conversation

@alexandru-pocovnicu
Copy link

@alexandru-pocovnicu alexandru-pocovnicu commented Jan 24, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implemented functions,debbuged errors using MDN an interpreted code

@alexandru-pocovnicu
commented on what "=" is doing
fa379f5
@alexandru-pocovnicu
extracted initials using template literals and assigned them to the v…
02ae32f 
…ariable initials
@alexandru-pocovnicu
Implement extraction of directory and extension parts from filePath
9b30a86
@alexandru-pocovnicu
Add clarification comment explaining the purpose of the num variable
a0b1773
@alexandru-pocovnicu
Comment out instructional lines to prevent execution
f25bd17
@alexandru-pocovnicu
use let instead of const to declare a variable
8f26910
@alexandru-pocovnicu
moved the log after the variable declaration
9fbc0b0
@alexandru-pocovnicu
Add clarification comment explaining the const vs let issue for age v…
364bd75 
…ariable
@alexandru-pocovnicu
Fix cardNumber type to string for correct slice operation
374a35f
@alexandru-pocovnicu
Rename variables to follow naming conventions and add comment about v…
1743941 
…ariable naming rules
@alexandru-pocovnicu
Fix typo in priceAfterOneYear conversion and update comments for clarity
b1ecc00
@alexandru-pocovnicu
added comments to answer the questions
198da68
@alexandru-pocovnicu
commented what each line of code is doing
d17370a
@alexandru-pocovnicu
Add answers to questions about console object and syntax
0f55e12
@github-actions

This comment has been minimized.

Sign in to view
@alexandru-pocovnicu alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
3 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@alexandru-pocovnicu alexandru-pocovnicu changed the title London|26-ITP-January|Alexandru Pocovnicu|Coursework/sprint 1 London|26-ITP-January|Alexandru Pocovnicu|Sprint 1|Coursework Jan 24, 2026
@alexandru-pocovnicu alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
cjyuan
cjyuan reviewed Feb 8, 2026
View reviewed changes
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 8, 2026
@alexandru-pocovnicu
Copy link
Author

alexandru-pocovnicu commented Feb 9, 2026

thank you

@alexandru-pocovnicu alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 9, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 10, 2026

All good now.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandru-pocovnicu @cjyuan