London|26-ITP-January|Alexandru Pocovnicu|Sprint 2|Acoursework #921
Open
alexandru-pocovnicu wants to merge 14 commits intoCodeYourFuture:mainfrom
Open
London|26-ITP-January|Alexandru Pocovnicu|Sprint 2|Acoursework #921alexandru-pocovnicu wants to merge 14 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu wants to merge 14 commits intoCodeYourFuture:mainfrom
Conversation
…lay function questions
This comment has been minimized.
This comment has been minimized.
alexandru-pocovnicu
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alexandru-pocovnicu
changed the title
This comment has been minimized.
This comment has been minimized.
alexandru-pocovnicu
changed the title
alexandru-pocovnicu
added
the
Needs Review
cjyuan
reviewed
Feb 12, 2026
| // =============> Write your prediction here: all 3 logs will be '3' | ||
|
|
||
| const num = 103; | ||
| // const num = 103; |
Contributor
There was a problem hiding this comment.
Note:
Deleting the global num is optional. Within the function block, num is resolved to the parameter num.
If you are interested in the topic, you can looking up these two concepts, identifier scope and identifier resolution, in the context of JavaScript programming. ChatGPT can give a good explanation.
Author
There was a problem hiding this comment.
thank you , i did indeed think wrongly that if a globally declared variable and a parameter shared the same name they would be the same thing
| // Use the MDN string documentation to help you find a solution | ||
| // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase | ||
| function upperSnakeCase(str){ | ||
| return str.toUpperCase().split(" ").join("_") |
Contributor
There was a problem hiding this comment.
Note: The two string methods .replace() and .replaceAll() can probably perform better on this task.
Comment on lines
7
to
18
| const minutes = time.slice(-2); | ||
| if (hours === 0) { | ||
| return `12:${minutes} am`; | ||
| } | ||
| if (hours === 12) { | ||
| return `12:${minutes} pm`; | ||
| } | ||
| if (hours > 12) { | ||
| return `${hours - 12}:00 pm`; | ||
| return `${hours - 12}:${minutes} pm`; | ||
| } | ||
| return `${time} am`; | ||
| } |
Contributor
There was a problem hiding this comment.
Can you make the format of the returned value more consistent?
Currently the formats of the return value of formatAs12HourClock("01:23") and formatAs12HourClock("13:23") are not quite the same.
cjyuan
added
Reviewed
Author
|
thank you |
alexandru-pocovnicu
added
Needs Review
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this repo I have predicted errors, interpreted error messages, debbuged and implemented functions according to requrements