Birmingham| ITP-Jan | Ahmad Roman Sanaye| Sprint 1| Structuring and Testing Data by RomanSanaye · Pull Request #958 · CodeYourFuture/Module-Structuring-and-Testing-Data

RomanSanaye · 2026-02-11T20:16:17Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes using Node
My changes follow the style guide

Changelist

Completed Sprint 1 exercises
Ran all files using Node to identify and understand errors
Added explanations and comments to interpret the code
Explored stretch tasks to reinforce understanding

hkavalikas · 2026-02-19T07:41:07Z

Sprint-1/1-key-exercises/3-paths.js

 const filePath = "/Users/mitch/cyf/Module-JS1/week-1/interpret/file.txt";
 const lastSlashIndex = filePath.lastIndexOf("/");
-const base = filePath.slice(lastSlashIndex + 1);
+const base = filePath.slice(-8);


We have updated the provided lastSlashIndex with a magic number like -8, what would happen if we now renamed our file.txt to best-file-ever.txt? Would this solution still work?

Thank you for the feedback! @hkavalikas 🙏
I removed the magic number and updated the logic to use lastIndexOf("/") to dynamically locate the last slash, combined with substring() to safely extract the file name.
With this approach, the code will continue to work correctly even if the file name changes .

hkavalikas · 2026-02-19T07:44:09Z

Sprint-1/1-key-exercises/4-random.js

 // Try logging the value of num and running the program several times to build an idea of what the program is doing
+
+// num is a variable that will be assigned an integer number after the operators are done.
+// Math.floor() rounds a decimal to its nearest number to make it an integer. ex = 1.2 => 1.


What would happen if we did Math.floor(1.9);?

Thanks for the feedback!
Math.floor() always rounds a number down to the nearest integer by removing the decimal part. Here it will return 1.

hkavalikas · 2026-02-19T07:44:44Z

Sprint-1/1-key-exercises/4-random.js

What does the + minimum do here?

Thank you for the feedback!
The + minimum shifts the random value into the desired range.
Without it, the formula would generate numbers between 0 and (maximum - minimum).
By adding minimum, the result is shifted to fall within the range of minimum to maximum (for example, 1 – 100).

hkavalikas · 2026-02-19T07:46:27Z

Sprint-1/2-mandatory-errors/0.js

+//solution: Simply comment the lines.
+// 1- single line comment like: // example ...
+// 2- multiline comment like : /* a, b, c */
+// comments are for instruction of guidance of who will read our codes, but the computer wont read them.


Explanation is spot on, let's take it a step further and execute it! I want to run this file without a syntax error. Can we make it possible?

Thank you for the feedback!
I have updated the file by commenting out the instructional lines so they are no longer executed by the interpreter.

hkavalikas · 2026-02-19T07:47:42Z

Sprint-1/2-mandatory-errors/1.js

-age = age + 1;
+//age = age + 1;
+
+// we can't do that with const variable, because JS locks the reference. 


Also spot on, let's take the approach and fix the broken code over declaring additional variables.

Thank you for the feedback!
I have updated the code by fixing the original variable instead of introducing additional variables.

hkavalikas · 2026-02-19T07:52:45Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

-
+    // we have variable declarations at lines 1, 2, 7 and 8.
 // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
+    // the purpose of that expression is to turn into number the string and replace all commas  with an empty space.


This comment is mostly correct, but I do want to highlight the second part of your answer. Is there anything we can do to improve it slightly?

Thank you for the feedback!
We improved the explanation: the expression Number(carPrice.replaceAll(",", "")) first removes all commas from the string (for example, "1,000" becomes "1000"), and then converts the cleaned string into a number (1000).

hkavalikas · 2026-02-19T07:54:42Z

Sprint-1/3-mandatory-interpret/2-time-format.js

+    // movieLength % 60 expression represents the remaining seconds.
 // d) Interpret line 4, what does the expression assigned to totalMinutes mean?
-
+    // that expression turns the seconds into minutes.


You are right, but let's try to break it down step by step, how is the expression doing that?

Thank you for the feedback!
I broke it down step by step:

movieLength % 60 gives the leftover seconds that don’t fit into a full minute.

movieLength - remainingSeconds removes those leftover seconds.

Dividing by 60 converts the remaining seconds into total minutes.

This shows clearly how the expression turns the total seconds into minutes while keeping track of leftover seconds.

hkavalikas · 2026-02-19T07:55:22Z

Sprint-1/3-mandatory-interpret/2-time-format.js

 // e) What do you think the variable result represents? Can you think of a better name for this variable?
-
+    // the result variable represents the movie length in Hour, minutes and seconds.
+    // a better name can be "movieLength".


Can you see any problem if we were to name it movieLength?

Thank you for the feedback!
If we name the final result variable movieLength, it could be confusing because we already have a variable movieLength holding the total seconds.
Using a different name, like movieDuration, makes the code clearer and avoids accidentally overwriting the original value.

hkavalikas · 2026-02-19T07:56:09Z

Sprint-1/3-mandatory-interpret/2-time-format.js

+    // the result variable represents the movie length in Hour, minutes and seconds.
+    // a better name can be "movieLength".
 // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
+    // as I changed the value of the movieLength the results has changed too.It means this code works with any value.


There are a few cases that might break this. Can you spot and mention a few?

Thank you for the feedback!
Some cases that could break the code include:

Negative numbers (a movie cannot have negative seconds)

Decimal numbers (like 8777.22)

Invalid inputs (like strings, null, or undefined)

Handling these cases ensures the program works safely and produces correct results.

hkavalikas · 2026-02-19T08:00:30Z

Sprint-1/4-stretch-explore/objects.md

Optional: There are a few questions before the "Answer the following questions" too, if you want to add an answer to those too for completeness.

Thank you for the feedback!
I have added answers to the optional questions for completeness.

…ll, random min, and safe movie length calculations with edge case handling

RomanSanaye added 5 commits February 11, 2026 11:45

1-key-exercises are done

739e416

Mandatory errors were fixed and Explained

f71288b

Mandatory interprets are done

bb852dd

Answere the questions in objects.md

242fca7

Answered the question about 'alert & prompt'

38532cf

RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026

This comment has been minimized.

Sign in to view

RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 12, 2026

hkavalikas self-requested a review February 19, 2026 07:23

hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 19, 2026

hkavalikas suggested changes Feb 19, 2026

View reviewed changes

hkavalikas added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 19, 2026

Fix PR feedback: lastSlashIndex, Math.floor(), const vs let, replaceA…

c3dd177

…ll, random min, and safe movie length calculations with edge case handling

Uh oh!

Comments

Conversation

RomanSanaye commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Self checklist

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RomanSanaye Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RomanSanaye commented Feb 11, 2026 •

edited

Loading

RomanSanaye Feb 19, 2026 •

edited

Loading