Skip to content

Cape Town| 25-SDC-July | Faith Muzondo | Sprint 4| Implement shell tools python#145

Open
Faithy4444 wants to merge 5 commits intoCodeYourFuture:mainfrom
Faithy4444:implement-shell-tools-python
Open

Cape Town| 25-SDC-July | Faith Muzondo | Sprint 4| Implement shell tools python#145
Faithy4444 wants to merge 5 commits intoCodeYourFuture:mainfrom
Faithy4444:implement-shell-tools-python

Conversation

@Faithy4444
Copy link

@Faithy4444 Faithy4444 commented Aug 4, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Faithy4444 Faithy4444 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2025
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 25, 2025
LonMcGregor
LonMcGregor reviewed Aug 25, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

You committed files that were not part of this PR - please be careful of that. Can you remove these from the "changed files" please?

Remember to update the default PR text when submitting on github.

Good work implementing the tasks - I have left some comments where you could improve further

implement-shell-tools/cat/my_cat.py
Copy link

@LonMcGregor LonMcGregor Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try running the original cat program and comparing your output, do you see any differences?

Also, there is some code duplication in here, can you figure out how to clean that up?

implement-shell-tools/wc/my_wc.py
Copy link

@LonMcGregor LonMcGregor Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some duplication of code here - can you think how to reduce this?

Copy link
Author

@Faithy4444 Faithy4444 Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have removed the duplicate code

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 25, 2025
@Faithy4444 Faithy4444 force-pushed the implement-shell-tools-python branch from 7bff937 to 3a7ef49 Compare October 23, 2025 02:06
@LonMcGregor
Copy link

LonMcGregor commented Oct 27, 2025

Good work

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 27, 2025
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Faithy4444 @LonMcGregor