London | SDC-Nov-25 | Emiliano Uruena | Sprint 2 | JSON jq exercise#235
London | SDC-Nov-25 | Emiliano Uruena | Sprint 2 | JSON jq exercise#235Emilianouz wants to merge 8 commits intoCodeYourFuture:mainfrom
Conversation
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, I've left some comments where you could improve the PR further
There was a problem hiding this comment.
This file doesn't need to be included in this PR for this sprint task, can you revert this please?
There was a problem hiding this comment.
It should be possible to solve this with a single | add command, can you figure out how?
This file doesn't belong to this module.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@Emilianouz To note why the bot is giving an error here, it looks like you have deleted the number systems file entirely. When you want to leave it unchanged in a pull request, you need to revert it back to the state it was in on the main branch. That way when you look at the changed files section in the PR here on github, it doesn't show up at all. |
@LonMcGregor Thank you for your advice. |
|
@Emilianouz An easy way to revert any file to its original state is to use the following command |
This comment has been minimized.
This comment has been minimized.
I ran the command to restore the file. When I tried to pull, an error occurred, so I had to merge. However, it still isn’t validated. |
|
You should not need to pull or merge anything. If you pull and merge from your branch, do you remember what that does? it takes the existing changes and adds them back in. |
This reverts commit 8fb3596. q
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work - this PR is now only focused on the jq tasks
Changelist
Exercises key jq logic to process JSON files: person and scores effectively.
Over person data, extracting and format names and locations.
Calculating each player's infor and score, using pipelines and add function.