Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 3 | Implement Shell Tools#244
Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 3 | Implement Shell Tools#244RahwaZeslusHaile wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
RahwaZeslusHaile
added
the
Needs Review
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
bot
removed
the
Needs Review
RahwaZeslusHaile
added
the
Needs Review
| program | ||
| .name("myls") | ||
| .description("Custom implementation of ls") | ||
| .option("-1", "list one file per line (default in our version)") |
There was a problem hiding this comment.
if -1 is the default, how can you test with this turned off?
There was a problem hiding this comment.
@LonMcGregor thank you .Good point — since this implementation only supports -1 output, I’ve made the -1 flag required rather than treating it as a default. This makes the behaviour explicit and testable.
There was a problem hiding this comment.
Good work making these changes. You've made this now a required flag. What does this mean? If the flag is always required and always active, how would you test the alternative, of having the output on a single line?
There was a problem hiding this comment.
@LonMcGregor, you’re right — making the flag always required means it’s always active, so I wouldn’t be able to test the alternative output (without the single-line format). I updated the implementation so the -1 flag is optional, allowing the script to produce multi-column output when it’s not provided.
Thanks for the feedback!
LonMcGregor
added
Reviewed
RahwaZeslusHaile
added
the
Needs Review
LonMcGregor
removed
the
Needs Review
RahwaZeslusHaile
added
the
Needs Review
|
Good work! This task is finished now |
LonMcGregor
added
Complete
2 participants
Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 3 | Implement Shell Tools
Learners, PR Template
Self checklist
Changelist
Commander: cat → view file contents, ls → list files/folders, wc → count lines/words/characters.
Questions
I know Linux and Unix commands may behave slightly differently. I ran these commands (cat, ls, wc) on my Mac — if you are running on other operating rather than unix ,Would you take that into consideration?