London | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 4 | Implement Shell Tools-Python#261
London | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 4 | Implement Shell Tools-Python#261zohrehKazemianpour wants to merge 11 commits intoCodeYourFuture:mainfrom
Conversation
zohrehKazemianpour
added
the
Needs Review
LonMcGregor
added
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
implement-shell-tools/cat/cat.py
Outdated
| numbered_line = f"{line_number:6}\t{line}" | ||
| numbered_lines.append(numbered_line) | ||
|
|
||
| print("\n".join(numbered_lines)) # LEVEL 3: inside if |
There was a problem hiding this comment.
Here you are doing the same thing in both if conditions, setting up a list of lines and then printing. Could you reduce some of the code duplication?
There was a problem hiding this comment.
Good catch! I refactored it to use a single output list and one print statement instead of repeating the same code in both conditions.
implement-shell-tools/ls/ls.py
Outdated
| files = [f for f in files if not f.startswith('.')] | ||
|
|
||
| for file in files: | ||
| print(file) No newline at end of file |
There was a problem hiding this comment.
Did you test this program without the -1 option?
There was a problem hiding this comment.
You're right. It was always printing one per line! Fixed it to use different separators based on the flag.
implement-shell-tools/wc/wc.py
Outdated
| total_words += words | ||
| total_chars += chars | ||
|
|
||
| if args.lines: |
There was a problem hiding this comment.
Did you test with multiple arguments given at once?
There was a problem hiding this comment.
The elif was the problem, only one branch would execute. Switched to independent if statements, so multiple flags work together now.
implement-shell-tools/wc/wc.py
Outdated
| elif args.chars: | ||
| print(f"{total_chars:8} total") | ||
| else: | ||
| print(f"{total_lines:8}{total_words:8}{total_chars:8} total") |
There was a problem hiding this comment.
Do you see the repetition in the structure of the code here? Could that be reduced somehow?
There was a problem hiding this comment.
Yes, same duplication issue here. Applied the same fix, building the output dynamically instead of having separate branches for each case.
LonMcGregor
added
Reviewed
Thanks for the review and feedback! I've implemented all the changes you suggested. |
zohrehKazemianpour
added
the
Needs Review
2 participants
Self checklist
This PR contain implementing Shell tools cat, ls, and wc commands in Python.
This was my first time working with Python! The syntax felt familiar coming from JavaScript, though I had to get used to indentation being required and some differences like
len()vs.length.