-
-
Notifications
You must be signed in to change notification settings - Fork 31
fix(graph): route the four spacetime sliders into d3 forces in non-galaxy mode #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Coding-Dev-Tools
wants to merge
21
commits into
main
Choose a base branch
from
ship/gravity-sliders-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
434a94c
fix(graph): route the four spacetime sliders into d3 forces in non-ga…
Coding-Dev-Tools d700bba
fix(graph): preserve default force strength when the spacetime slider…
Coding-Dev-Tools 8ff0dbf
Merge remote-tracking branch 'origin/main' into ship/gravity-sliders-fix
Coding-Dev-Tools 8d42016
fix(review): address PR #177 codex reviews (round 6) — consume normal…
Coding-Dev-Tools ee514b7
fix(review): address the actual slider flicker — rebalance the
Coding-Dev-Tools 91e5d0f
fix(review): bypass the 2x response gain for the spacetime sliders so
Coding-Dev-Tools fddfd94
fix(graph): restore the galaxy physics 0..8/0..16 calibration scale
Coding-Dev-Tools 573ec4a
test(graph): verify slider forces and cache bust
Coding-Dev-Tools f18d5f4
fix: bound galaxy orbit speeds after control
Coding-Dev-Tools 7ecc605
preserve normalized Galaxy physics controls
Coding-Dev-Tools 5f0e5d3
fix vector speed caps and oversized graph controls
Coding-Dev-Tools c2e79e3
update normalized Galaxy field expectation
Coding-Dev-Tools afef952
stabilize Galaxy paint audit baseline
Coding-Dev-Tools fe00c88
cap kinematic galaxy carrier speed
Coding-Dev-Tools 031ee8f
cap live Galaxy carrier velocity
Coding-Dev-Tools f1b23d4
fix(graph): expose spacetime tuning in every preset
Coding-Dev-Tools 90efe82
fix(graph): bound kinematic velocity and control response
Coding-Dev-Tools 7f4f1ac
fix(graph): wire spacetime controls into every renderer
Coding-Dev-Tools 39aa7e8
fix(graph): bound full-layout physics controls
Coding-Dev-Tools 1e05eb5
fix(graph): share capped speed across orbit phase
Coding-Dev-Tools d5f4244
fix(graph): keep settling resistance responsive
Coding-Dev-Tools File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In All Nodes mode, setting Link spring to its supported minimum of
0still leaves every linked-pair attraction at 35% strength becausespringScaleevaluates to0.35. This makes the zero endpoint misleading and inconsistent with the normalized multiplier used by the Galaxy path; map zero to zero while retaining the neutral scale at the default value.Useful? React with 👍 / 👎.