fix: general quality of service improvements#167
Open
CodingAleCR wants to merge 7 commits intomainfrom
Open
Conversation
096a4ab to
84220b8
Compare
There was a problem hiding this comment.
Bug: CopyWith Mutates Original MultipartRequest Files
The MultipartRequest.copyWith method calls file.finalize() on the original MultipartFile objects. Since finalize() consumes the file's stream and can only be called once, this makes the original request's files unusable and can result in the copied request having invalid or empty file contents if the originals were already finalized. This violates the non-mutating behavior expected from copyWith().
lib/extensions/multipart_request.dart#L25-L44
http_interceptor/lib/extensions/multipart_request.dart
Lines 25 to 44 in 7a57b40
Was this report helpful? Give feedback by reacting with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.