Conversation
… doesn't have the same behavior
Lenaick
requested review from
Timmy38 and
Copilot
and removed request for
Copilot
July 27, 2026 13:31
Contributor
|
| Filename | Overview |
|---|---|
| setup/wizardsteps/WizStepModulesChoice.php | Refines extension choice flags and navigation checks for installed extensions with dependency issues. |
| tests/php-unit-tests/unitary-tests/setup/WizStepModulesChoiceTest.php | Updates and expands unit cases for dependency, installation, mandatory, and uninstallability combinations. |
Reviews (2): Last reviewed commit: "N°9116 - Installing modules in extension..." | Re-trigger Greptile
… doesn't have the same behavior
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns setup behavior for extensions from local and production module folders when dependencies are missing.
Changes:
- Refines extension selection flags based on source and uninstallability.
- Updates forward-navigation blocking rules.
- Expands flag test scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
setup/wizardsteps/WizStepModulesChoice.php |
Updates selection and navigation logic. |
tests/php-unit-tests/unitary-tests/setup/WizStepModulesChoiceTest.php |
Adjusts expected flags and adds scenarios. |
Comments suppressed due to low confidence (1)
setup/wizardsteps/WizStepModulesChoice.php:825
- This changes when the wizard's Next action is blocked, but the updated tests only assert
ComputeChoiceFlags.ProviderDisplayOptionschecks rendered HTML, and there is no assertion ofJSCanMoveForward, so regressions in the new installed/mandatory/uninstallable/dependency combinations will pass. Please cover the allowed-uninstall case, the non-uninstallable/mandatory blocked cases, and the force-uninstall bypass.
if (!$aFlags['checked'] && $aFlags['installed'] && !$bDisableUninstallCheck && (!$aFlags['uninstallable'] || $aFlags['mandatory'])) {
// If the user cannot uninstall a mandatory extension, he cannot move forward unless he uses the "force-uninstall" option
// The same applies if the extension is not uninstallable (i.e. a product extension)
$this->bCanMoveForward = false;
} elseif ($aFlags['checked'] && $aFlags['disabled'] && $aFlags['dependency_issue'] && !$bDisableUninstallCheck) {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if ($bMissingFromDisk) { | ||
| $bDisabled = true; | ||
| $bChecked = false; | ||
| } elseif ($bDependencyIssue && ($oITopExtension->sSource !== iTopExtension::SOURCE_WIZARD || !$bMandatory)) { |
Timmy38
approved these changes
Jul 28, 2026
… doesn't have the same behavior
Lenaick
deleted the
feature/9116-installing-modules-in-extension-folder-or-production-modules-doesn-t-have-the-same-behavior
branch
July 28, 2026 14:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N°9116 - Installing modules in extension folder or production-modules doesn't have the same behavior