Skip to content

N°9800 sample data finalization - #982

Merged
v-dumas merged 11 commits into
developfrom
feature/9800-sample-data-finalization
Jul 27, 2026
Merged

N°9800 sample data finalization#982
v-dumas merged 11 commits into
developfrom
feature/9800-sample-data-finalization

Conversation

@v-dumas

@v-dumas v-dumas commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Base information

Question Answer
Related to a Combodo ticket? N°9800
Type of change? Bug fix / Enhancement / Translations

Symptom (bug) / Objective (enhancement)

Add sample data on FAQs and Known Errors
Fix typos in other sample data User, and french Services

Proposed solution (bug and enhancement)

Same as other sample in XML

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand without digging in the code?

Copilot AI review requested due to automatic review settings July 27, 2026 13:32
@CombodoApplicationsAccount CombodoApplicationsAccount added the internal Work made by Combodo label Jul 27, 2026
@greptile-apps

greptile-apps Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR expands localized sample content and corrects existing seed-data text.

  • Adds localized FAQ domains, categories, and FAQ records and registers them for optional sample installation.
  • Adds localized Known Error records and KnownError-to-FunctionalCI sample links.
  • Corrects French service labels and sample-user details.

Confidence Score: 3/5

This PR should not merge until the dangling FunctionalCI reference in the Known Error sample links is corrected.

Sample installation cannot resolve FunctionalCI external ID 1, so one newly introduced KnownError-to-CI link is persisted without a valid target.

Files Needing Attention: datamodels/2.x/itop-knownerror-mgmt/data/data.sample.errortofunctionalci.xml

Important Files Changed

Filename Overview
datamodels/2.x/itop-faq-light/module.itop-faq-light.php Registers the English anchor files for automatically localized FAQ domain, category, and record samples in dependency-safe order.
datamodels/2.x/itop-knownerror-mgmt/module.itop-knownerror-mgmt.php Registers localized Known Error data before its CI-link sample file.
datamodels/2.x/itop-knownerror-mgmt/data/data.sample.errortofunctionalci.xml Adds four KnownError-to-CI links, one of which references nonexistent FunctionalCI external ID 1 and remains unresolved.
datamodels/2.x/itop-knownerror-mgmt/data/data.sample.knownerror.en_us.xml Adds two English Known Error sample records whose IDs remain consistent across localized variants.

Reviews (1): Last reviewed commit: "N°9800 - New sample data for KnownError ..." | Re-trigger Greptile

Comment thread datamodels/2.x/itop-knownerror-mgmt/data/data.sample.errortofunctionalci.xml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds localized FAQ and Known Error sample data for ticket N°9800 and corrects existing user/service fixtures.

Changes:

  • Adds English, French, and German FAQ and Known Error samples.
  • Registers new localized sample files and CI links.
  • Fixes a sample password and French service translations.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
datamodels/2.x/itop-structure/data/data.sample.users.xml Corrects ConfigManager password data.
datamodels/2.x/itop-service-mgmt/data/data.sample.services.fr_fr.xml Translates a service into French.
datamodels/2.x/itop-service-mgmt-provider/data/data.sample.services.fr_fr.xml Translates the provider service.
datamodels/2.x/itop-knownerror-mgmt/module.itop-knownerror-mgmt.php Registers Known Error samples.
datamodels/2.x/itop-knownerror-mgmt/data/data.sample.knownerror.fr_fr.xml Adds French Known Errors.
datamodels/2.x/itop-knownerror-mgmt/data/data.sample.knownerror.en_us.xml Adds English Known Errors.
datamodels/2.x/itop-knownerror-mgmt/data/data.sample.knownerror.de_de.xml Adds German Known Errors.
datamodels/2.x/itop-knownerror-mgmt/data/data.sample.errortofunctionalci.xml Links errors to CIs.
datamodels/2.x/itop-faq-light/module.itop-faq-light.php Registers localized FAQ samples.
datamodels/2.x/itop-faq-light/data/data.sample.faqdomain.fr_fr.xml Adds French FAQ domains.
datamodels/2.x/itop-faq-light/data/data.sample.faqdomain.en_us.xml Adds English FAQ domains.
datamodels/2.x/itop-faq-light/data/data.sample.faqdomain.de_de.xml Adds German FAQ domains.
datamodels/2.x/itop-faq-light/data/data.sample.faqcategory.fr_fr.xml Adds French FAQ categories.
datamodels/2.x/itop-faq-light/data/data.sample.faqcategory.en_us.xml Adds English FAQ categories.
datamodels/2.x/itop-faq-light/data/data.sample.faqcategory.de_de.xml Adds German FAQ categories.
datamodels/2.x/itop-faq-light/data/data.sample.faq.fr_fr.xml Adds French FAQ articles.
datamodels/2.x/itop-faq-light/data/data.sample.faq.en_us.xml Adds English FAQ articles.
datamodels/2.x/itop-faq-light/data/data.sample.faq.de_de.xml Adds German FAQ articles.
datamodels/2.x/itop-faq-light/data/data.sample.faq-domains.xml Removes the superseded domain fixture.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread datamodels/2.x/itop-knownerror-mgmt/data/data.sample.errortofunctionalci.xml Outdated
Comment thread datamodels/2.x/itop-faq-light/data/data.sample.faq.en_us.xml Outdated
Comment thread datamodels/2.x/itop-faq-light/data/data.sample.faq.fr_fr.xml Outdated
Comment thread datamodels/2.x/itop-faq-light/data/data.sample.faq.de_de.xml Outdated
Comment thread datamodels/2.x/itop-faq-light/data/data.sample.faqcategory.en_us.xml Outdated
Comment thread datamodels/2.x/itop-knownerror-mgmt/data/data.sample.knownerror.fr_fr.xml Outdated
Comment thread datamodels/2.x/itop-knownerror-mgmt/data/data.sample.knownerror.fr_fr.xml Outdated
Comment thread datamodels/2.x/itop-faq-light/data/data.sample.faq.en_us.xml Outdated
Comment thread datamodels/2.x/itop-faq-light/data/data.sample.faqdomain.fr_fr.xml Outdated
v-dumas and others added 9 commits July 27, 2026 17:54
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@v-dumas
v-dumas merged commit 56d7e40 into develop Jul 27, 2026
@v-dumas
v-dumas deleted the feature/9800-sample-data-finalization branch July 27, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants