N°9861 - Keep current choice button is too permissive

[Lenaick]

N°9861 - Keep current choice button is too permissive

[greptile-apps]

Greptile Summary

The PR adds extension-choice validation before the setup wizard enters data audit and redirects invalid selections to the latest module-choice step.

• Extracts the extension forward-navigation check into a reusable helper.
• Adds controller support for resolving the latest state of a step class.
• Synchronizes the in-memory wizard-step stack when the intermediate wizard is skipped.

Confidence Score: 4/5

The PR does not appear safe to merge until landing-step validation reads the correct per-step extension selection map.

The existing reported issue remains: the landing step passes a per-step outer array into a function that performs top-level choice-ID lookups, allowing valid installed extension choices to be classified as unchecked and redirecting the user away from data audit.

Files Needing Attention: setup/wizardsteps/WizStepLandingBeforeAudit.php

Important Files Changed

Filename	Overview
setup/wizardsteps/WizStepLandingBeforeAudit.php	Adds pre-audit extension validation and redirects rejected selections to the module-choice step.
setup/wizardsteps/WizStepModulesChoice.php	Refactors existing extension forward-navigation conditions into a reusable helper.
setup/wizardcontroller.class.inc.php	Exposes stack popping and adds lookup of the latest recorded state for a wizard-step class.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Landing before audit] --> B[Load selected components]
    B --> C[Compute extension choice flags]
    C --> D{Choices allow forward navigation?}
    D -->|Yes| E[Data audit]
    D -->|No| F[Latest modules-choice step]

Loading

_{Reviews (3): Last reviewed commit: "N°9861 - Changes from review" | Re-trigger Greptile}

[Copilot]

Pull request overview

Prevents “Keep current choices” from bypassing incompatible extension selections during upgrades.

Changes:

• Reuses extension eligibility checks through a dedicated helper.
• Redirects incompatible selections to the final module-choice step.
• Allows that redirect through the wizard step contract.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
setup/wizardsteps/WizStepModulesChoice.php	Extracts reusable forward-navigation validation.
setup/wizardsteps/WizStepLandingBeforeAudit.php	Validates retained extensions and redirects incompatible choices.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bdalsass]

Seems good but maybe requires review of a knowledgeable contributor on the subject