Multiple renames for clarity and consistency by nstepien · Pull Request #3967 · Comcast/react-data-grid

nstepien · 2026-02-21T04:29:53Z

I've renamed a few components/types for clarity and consistency.

Removed "formatter" from names, it's legacy nomenclature
Removed "renderer" from some names, virtually all React components are "renderers" so it's redundant.
It's like naming components *Component.
To help differentiate between the renderers.renderCell and column.renderCell,
I've changed some names from *CellProps to *CellContentProps for example
Removed some default exports so we use the same named import everywhere

Breaking changes:

cell content:
- RenderCellProps -> RenderCellContentProps
- RenderHeaderCellProps -> RenderHeaderCellContentProps
- RenderSummaryCellProps -> RenderSummaryCellContentProps
- RenderGroupCellProps -> RenderGroupCellContentProps
- RenderEditCellProps -> RenderEditCellContentProps
CellRendererProps -> RenderCellProps
- while this is consistent with everything else now (Render*Props pattern), it'll conflict with the older RenderCellProps type name, need to be careful when updating RDG
- the new RenderCellProps has a different shape and no default for TSummaryRow, so code still using the old RenderCellProps fails type checking instead of silently changing meaning
SelectCellFormatter -> SelectCheckbox
RenderRowProps['activeCellEditor'] is now typed with the props the editor cell actually receives, instead of RenderEditCellProps

Other changes:

Cell events (CellMouseEvent, CellKeyboardEvent) now inherit from the React event instead of copying its properties. As with React events, currentTarget is null after the handler returns.
useLatestFunc is typed without any or @ts-expect-error
TreeDataGrid groups rows without allocating temporary arrays
README: the *ContentProps types and the default content renderers are described as cell content renderers, and rowGrouper and groupIdGetter have performance notes
Website: renamed demo components (CellExpanderFormatter -> CellExpander, DraggableRowRenderer -> DraggableRow, FilterRenderer -> FilterCell), and the infinite scrolling demo uses useTransition

codecov-commenter · 2026-02-21T04:35:56Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.35%. Comparing base (6f1f5cf) to head (618d87b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3967   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files          45       45           
  Lines        1951     1951           
  Branches      727      727           
=======================================
  Hits         1919     1919           
  Misses         32       32

Files with missing lines	Coverage Δ
src/Cell.tsx	`100.00% <100.00%> (ø)`
src/Columns.tsx	`100.00% <100.00%> (ø)`
src/DataGrid.tsx	`98.88% <100.00%> (+<0.01%)`	⬆️
src/EditCell.tsx	`97.14% <ø> (ø)`
src/GroupedRow.tsx	`100.00% <100.00%> (ø)`
src/Row.tsx	`100.00% <100.00%> (ø)`
src/SummaryCell.tsx	`100.00% <ø> (ø)`
src/TreeDataGrid.tsx	`94.44% <100.00%> (+0.03%)`	⬆️
src/cellRenderers/SelectCheckbox.tsx	`100.00% <100.00%> (ø)`
src/cellRenderers/renderToggleGroup.tsx	`100.00% <100.00%> (ø)`
... and 6 more

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nstepien · 2026-02-23T22:31:50Z

+    function groupRows(
      rows: readonly R[],
-      [groupByKey, ...remainingGroupByKeys]: readonly string[],
+      groupByIndex: number,


Refactored this so we don't allocate temp arrays

nstepien · 2026-02-23T22:55:49Z

+  fn: Maybe<(...args: Args) => void>
+): Maybe<(...args: Args) => void>;
+
+export function useLatestFunc<Args extends unknown[]>(fn: Maybe<(...args: Args) => void>) {


We can implement this without any/@ts-expect-error!

Don't think I fully understand this TS code :)

Me neither, it's some technical limitation of using unknown vs any I guess 🤷‍♂️

nstepien · 2026-02-23T22:57:38Z

-  Object.setPrototypeOf(cellEvent, Object.getPrototypeOf(event));
-
-  return cellEvent;
+  });


This creates a new object that inherits from the event object, and adds preventGridDefault/isGridDefaultPrevented property descriptors

WDYT?

nstepien · 2026-02-23T23:01:39Z

    const columnWidth = getColumnWidth(column);
    const colSpan = column.colSpan?.({ type: 'ROW', row: rows[rowIdx] }) ?? 1;
-    const { insetInlineStart, ...style } = getCellStyle(column, colSpan);
+    const style = getCellStyle(column, colSpan);


Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

React does not mark state updates after an `await` as part of the transition, so `setRows` committed in a separate render from `isPending` turning false, briefly showing the loading message over the new rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

The descriptions of the `*ContentProps` types and of the default content renderers still called them cell renderers, the term `RenderCellProps` now uses for `renderers.renderCell`. Call them cell content renderers, and name the column property each type is for. Also restore the sorted order of two type import lists that the `CellRendererProps` -> `RenderCellProps` rename had broken. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

They hold `format` functions now, not `Intl` formatter objects, so call them `formatDate` and `formatCurrency`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Stacked on #3967. Cell events inherit from React's event, but React's `stopPropagation()` and `preventDefault()` store their state on the object they're called on. When called on a cell event, they updated the cell event instead of React's event, so: - `stopPropagation()` in `onCellClick`, `onCellKeyDown`, or another cell event handler didn't stop React from calling parent handlers. - After `preventDefault()`, parent handlers saw `isDefaultPrevented()` return `false`. The native event was still updated, so the browser's default action was prevented. This predates #3967: cell events used to copy React's event, with the same result. Cell events now call these two methods on React's event. The two new tests failed in all three browsers before the fix. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

amanmahajan7 · 2026-10-22T00:08:31Z

+  fn: Maybe<(...args: Args) => void>
+): Maybe<(...args: Args) => void>;
+
+export function useLatestFunc<Args extends unknown[]>(fn: Maybe<(...args: Args) => void>) {


Don't think I fully understand this TS code :)

amanmahajan7 · 2026-10-22T00:11:30Z

+    startTransition(async () => {
+      const newRows = await loadMoreRows(50, rows.length);
+      // state updates after `await` must be wrapped in another transition
+      startTransition(() => {


For my understand, does the isPending flag stay true until both transitions are complete?

Yes.
The nested startTransition is necessary otherwise React wouldn't know that the nested state update is part of this transition.
https://react.dev/reference/react/useTransition#react-doesnt-treat-my-state-update-after-await-as-a-transition

Multiple renames for clarity and consistency

e1e83d1

nstepien added 4 commits February 23, 2026 22:07

Merge remote-tracking branch 'origin/main' into clarity

83674a9

fix SelectCellKeyDownArgs type in README

4ba6b57

lint

944babe

tweak SortableHeaderCell

07e3af6

nstepien self-assigned this Feb 23, 2026

nstepien added 2 commits February 23, 2026 22:49

tweak EditCell

548fc22

fix selectedCellEditor type

6cffef1

nstepien commented Feb 23, 2026

View reviewed changes

GroupRowRendererProps -> GroupedRowProps

794687c

nstepien marked this pull request as ready for review February 23, 2026 23:26

nstepien requested a review from amanmahajan7 as a code owner February 23, 2026 23:26

nstepien added 4 commits February 24, 2026 22:54

Merge branch 'main' into clarity

4b4318b

Merge branch 'main' into clarity

453e458

Merge branch 'main' into clarity

d5f94fa

Merge branch 'main' into clarity

1f09988

nstepien force-pushed the clarity branch from aec3d0f to 1f09988 Compare March 5, 2026 13:55

nstepien and others added 12 commits March 5, 2026 14:03

Merge branch 'main' into clarity

cb4eff9

Merge branch 'main' into clarity

007fd79

Merge branch 'main' into clarity

9306b3f

Merge branch 'main' into clarity

b2da515

Merge branch 'main' into clarity

d9ac713

Merge branch 'main' into clarity

fd88bc8

Merge branch 'main' into clarity

6d4c58a

Merge branch 'main' into clarity

bd3196b

Merge branch 'main' into clarity

19dc6f9

fix typos

6fefa25

Merge branch 'main' into clarity

acd6f65

Merge branch 'main' into clarity

dd4d7e6

nstepien and others added 9 commits July 26, 2026 22:42

Merge branch 'main' into clarity

58f38fc

Merge branch 'main' into clarity

75279d8

Merge branch 'main' into clarity

a394914

Merge branch 'main' into clarity

0010884

Merge branch 'main' into clarity

7ab1e03

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tweak a few imports

6ede10b

website: rename dateFormatter and currencyFormatter

618d87b

They hold `format` functions now, not `Intl` formatter objects, so call them `formatDate` and `formatCurrency`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

nstepien mentioned this pull request Oct 21, 2026

Fix stopPropagation() and preventDefault() on cell events #4217

Merged

nstepien added this pull request to stack #4218 October 21, 2026 22:07

nstepien merged commit e5742ee into main Oct 21, 2026
6 checks passed

nstepien deleted the clarity branch October 21, 2026 23:04

amanmahajan7 reviewed Oct 22, 2026

View reviewed changes

Navigation Menu

Repository navigation

Multiple renames for clarity and consistency - #3967

Multiple renames for clarity and consistency#3967
nstepien merged 33 commits into
mainfrom
clarity

nstepien commented Feb 21, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Feb 21, 2026 •

edited

Loading

Uh oh!

nstepien Feb 23, 2026 •

edited

Loading

Uh oh!

nstepien Feb 23, 2026

Uh oh!

amanmahajan7 Oct 22, 2026

Uh oh!

nstepien Oct 22, 2026

Uh oh!

nstepien Feb 23, 2026

Uh oh!

Uh oh!

nstepien Feb 23, 2026

Uh oh!

Uh oh!

amanmahajan7 Oct 22, 2026

Uh oh!

amanmahajan7 Oct 22, 2026

Uh oh!

nstepien Oct 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nstepien commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nstepien Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nstepien commented Feb 21, 2026 •

edited

Loading

codecov-commenter commented Feb 21, 2026 •

edited

Loading

nstepien Feb 23, 2026 •

edited

Loading