Skip to content

Problems with InternalsVisibleTo #441

Open

Description

@Arlodotexe

Worth noting our use of InternalsVisibleTo are using or being used by same set of components that keep appearing in these issues-- Behaviors, Animations, Media and Extensions.

If our use of InternalsVisibleTo is indeed related to our AoT issues on Wasdk as well as what we've seen here regarding transient dependencies, it might be highlighting a deeper issue with how we've set up these libraries.

We might want to go through and see if we can remove the need for these InternalsVisibleTo, it looks like at least a few are just to avoid helper duplication. If it fixes any of the issues we've listed throughout this ticket, we've narrowed the scope of our search down considerably.

Originally posted by @Arlodotexe in #169 (comment)

Activity

  1. moved this to 🔖 Ready in Toolkit 8.xon Jun 27, 2024
  2. moved this from 🔖 Ready to 🏗 In progress in Toolkit 8.xon Jul 1, 2024
  3. Arlodotexe commented on Jul 2, 2024

    @Arlodotexe
    MemberAuthor

    Adding additional details highlighted in #446:

    We're testing these changes for three reasons:

    The third reason is dismissed, CommunityToolkit/Tooling-Windows-Submodule#195 (comment) helped us verify that it was unrelated, and the fix offered by Mano and yourself @Sergio0694 double confirms that.

    The first two are still a possible concern. If we can verify that the use of InternalsVisibleTo here isn't uncovering some platform bug causing #169, we can dismiss that as well and close this PR without merging.

  4. moved this from 🏗 In progress to 📋 Backlog in Toolkit 8.xon Jul 8, 2024
  5. moved this from 📋 Backlog to 🏗 In progress in Toolkit 8.xon Jul 11, 2024
  6. self-assigned this
    on Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingnativeaotThe dependency on dotnet NativeAOT

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions