Skip to content

Pixel Size/Scaling Cleanup - #1396

Merged
garrettwrong merged 11 commits into
developfrom
dspf_pfds
Jul 28, 2026
Merged

Pixel Size/Scaling Cleanup#1396
garrettwrong merged 11 commits into
developfrom
dspf_pfds

Conversation

@garrettwrong

Copy link
Copy Markdown
Collaborator

Cleans up multiple issues with pixel size across the image/xform/filter/source components.

Resolves #1318 and fixes the introduced bugs, closing #1395 .

Adds unit tests covering the triggering situations of the bugs.

This should probably be rebased after the larger PR 1388.


Ironically, it was the single # Assign correct pixel_size line in Simulation that caused all the original problems, because it was assigning the wrong pixel_size under downsampling.

This caused some bugs (the math error in 1395) to be cancelled out, and workarounds to be added in other components... most of which I think only worked for Simulations, not real data.... Hopefully that's better now.

@garrettwrong garrettwrong self-assigned this Jul 14, 2026
@garrettwrong garrettwrong added bug Something isn't working cleanup labels Jul 14, 2026
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (5836ad2) to head (822bc17).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1396      +/-   ##
===========================================
+ Coverage    90.65%   90.66%   +0.01%     
===========================================
  Files          135      135              
  Lines        14926    14921       -5     
===========================================
- Hits         13531    13528       -3     
+ Misses        1395     1393       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@garrettwrong
garrettwrong marked this pull request as ready for review July 28, 2026 15:40
@garrettwrong
garrettwrong requested a review from janden as a code owner July 28, 2026 15:40
@garrettwrong
garrettwrong merged commit c531848 into develop Jul 28, 2026
58 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant