Skip to content

feat(kube)!: remove compatibility shims and sharpen stream/save plans - #31

Merged
sunib merged 2 commits into
mainfrom
refactor/crisp-api-and-plans
Sep 11, 2026
Merged

feat(kube)!: remove compatibility shims and sharpen stream/save plans#31
sunib merged 2 commits into
mainfrom
refactor/crisp-api-and-plans

Conversation

@sunib

@sunib sunib commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Remove obsolete pre-1.0 compatibility surfaces and make the stream/save plan describe remaining work. The current API is SubjectAccessReviewAuthorizer and the maintained npm package is @configbutler/krm-stream.

Proposal 0006 now contains four priorities with acceptance criteria, linking standing policy and shipped adoption behavior instead of duplicating them. Proposal 0005 retains the relevant tradeoffs and drops superseded phases and review history. The saving/Vue guides clarify user outcomes, receipt-only responses and edit-time deletion recovery; tested deletion-copy and keep-local recipes remain explicit follow-ups.

The removal commit carries the breaking-change footer. Changelogs remain generated by Release Please. Existing wire behavior and supported Kubernetes list/watch fallback are unchanged.

Validation on the final source tree:

  • task fixtures-check test lint pack-client passed, including gateway race tests, kube tests, 104 client tests, two Vue tests and package entry-point validation.
  • Checked 74 local documentation links/anchors, balanced fences, unchanged retained Mermaid blocks and git diff --check.
  • Real-cluster and local browser/wire integration were not run; the planned API composition and capacity claims remain unverified.

BREAKING CHANGE: SSARAuthorizer has been removed; use SubjectAccessReviewAuthorizer. The local unscoped krm-stream forwarding package has been removed; use @configbutler/krm-stream.

…ion plans

BREAKING CHANGE: SSARAuthorizer has been removed; use SubjectAccessReviewAuthorizer. The local unscoped krm-stream forwarding package has been removed; use @configbutler/krm-stream.
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1a2815fe-677f-40ca-9276-bf028cecbb7d

📥 Commits

Reviewing files that changed from the base of the PR and between f38e4ca and b163524.

📒 Files selected for processing (18)
  • CONTRIBUTING.md
  • README.md
  • docs/auth.md
  • docs/proposals/0005-kubernetes-stream-and-save-semantics.md
  • docs/proposals/0006-stream-and-save-implementation-plan.md
  • docs/releasing.md
  • docs/saving.md
  • docs/vue.md
  • examples/conditional-save/README.md
  • gateway/README.md
  • gateway/kube/authz.go
  • gateway/kube/authz_test.go
  • packages/krm-stream-compat/CHANGELOG.md
  • packages/krm-stream-compat/README.md
  • packages/krm-stream-compat/index.d.ts
  • packages/krm-stream-compat/index.js
  • packages/krm-stream-compat/package.json
  • packages/krm-stream/README.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sunib
sunib merged commit 7477c2d into main Sep 11, 2026
13 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant