feat(reports): preserve grouping-comparison residual delta for serialized successor - #835
Conversation
Caption leftover residual R on grouping comparison leftover-pair buttons through formatLeftoverMapResidual (ADR 0298). After make seed, closest and farthest leftover pairs sit above the member list with the Gabriel biplot of already-named coordinates and grouping comparison leftover-pair buttons that match R on the pair row; click a post marker or a pair button opens that post. A missing or non-finite R omits that leftover-map comparison residual badge and keeps leftover-map unexplained leftover U when finite. A finite negative leftover is shown, never clamped. Do not invent R from Y and E or from U and R̂. UI-only; no new columns. Never invent a leftover score or a theta. Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item-respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378-403. Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453-467.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cycle 2026-08-31 01:35 KST. Head Leave this PR open. Do not squash-merge onto the unprotected leftover base (#833). Do not self-approve. After independent review, retarget onto leftover-coordinates ( Parallel residual #834 on #832 is a competing stack of the same buyer gap; leave both open. Next increment on this head: leftover observed |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| const unexplainedLeftover = formatLeftoverMapUnexplained( | ||
| pair.leftover_map_unexplained, | ||
| ); | ||
| const residual = formatLeftoverMapResidual(pair.leftover_residual); |
There was a problem hiding this comment.
📝 Info: Residual remains persisted evidence
formatLeftoverMapResidual reads the comparison payload directly. Missing or non-finite residuals omit only this badge, preserving neighboring measurements.
Was this helpful? React with 👍 or 👎 to provide feedback.
| export const LEFTOVER_MAP_COMPARE_RESIDUAL_LABEL = | ||
| "Leftover map comparison residual"; |
There was a problem hiding this comment.
📝 Info: Signed residual values remain intact
The finiteness gate retains zero and negative residuals. Formatting matches the existing pair-row badge without clamping.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Cycle 2026-08-31 01:42 KST. Head |
seonghobae
added
enhancement
ChatGPT Codex Connector
seonghobae
changed the title
1 participant
Summary
Preserve the valid grouping-comparison persisted leftover residual
Rdelta while the serialized report stack is repaired. Missing/non-finiteRomits only that metric; finite zero and negative values remain explicit and are never clamped. UI/read-model composition only: no SQL/schema, theta authority, invented score, or hidden-population recomputation.Current serialized authority
The active repair order is #828 → #829 → #830 → #831 → #833 before this residual successor may be reconstructed.
1472d98b7513c360ca1c7cf6da4a401a716bc53c, Draft/RED. The merged dedicated accessibility regression proves the grouping axis-share generic<span>still carries an authoraria-label. Fresh owner review also verified that Proposed ADR0367, the v2.54.0 changelog,LEFTOVER_MAP_COMPARE_AXIS_SHARE_LABEL, and its inline i18n/test requirement still encode that invalid author-name contract. The parent repair must make source, regression, ADR, changelog, and dead label resources consistent while preserving the visible localized persisted axis/share formatter. Do not add a synthetic role.cad63edba68981a1ae3223e2f525284fc9d4ef0fon exact feat(reports): preserve grouping comparison axis-share delta for serialized successor #828. Its persisted unexplained-share transport/read-model repair is a valid distinct delta, but earlier-parent GREEN does not transfer across the pending feat(reports): preserve grouping comparison axis-share delta for serialized successor #828 movement.367498ed59396f490ce9b475175d748f7c43fc31on exact feat(reports): preserve grouping comparison unexplained-share delta for serialized successor #829. Its local axis-singular accessibility repair was verified on an earlier validation head; current ancestry still inherits feat(reports): preserve grouping comparison axis-share delta for serialized successor #828 RED and must be freshly reconverged after feat(reports): preserve grouping comparison axis-share delta for serialized successor #828/feat(reports): preserve grouping comparison unexplained-share delta for serialized successor #829 move.367498ed...; historical product head8a12062cd8efef0c99abe794ef3e9f8dcbc31617remains Draft/conflicting. Preserve its cross-share delta and Proposed ADR0372; reconstruct only after repaired feat(reports): preserve grouping comparison axis-share delta for serialized successor #828 → reconverged feat(reports): preserve grouping comparison unexplained-share delta for serialized successor #829 → reconverged feat(reports): preserve grouping comparison axis-singular delta for serialized successor #830. Do not allocate a release identity while that tree is stale.dbff5bf47b06eded0cff64b292815861d7f514f6on historical feat(reports): preserve grouping comparison cross-share delta for serialized successor #831. It owns the serialized unexplained-leftoverUsuccessor and must reconstruct after feat(reports): preserve grouping comparison cross-share delta for serialized successor #831 while explicitly inheriting every valid feat(reports): preserve unexplained-leftover comparison delta pending successor verification #832 recovery delta/test/fixture/contract/evidence item. Historical ADR0297/v2.54.0 is evidence only because current feat(reports): preserve grouping comparison axis-share delta for serialized successor #828 owns v2.54.0.This PR remains based on historical
#833@dbff5bf...with headf0da90928f0a01ba46ad82f3c53104edc910a630. Do not move or promote this residual product tree ahead of repaired #833. When #833 advances, reconstruct this child non-force from the exact repaired parent and regenerate all non-transferable evidence.Decision/release identity
Historical ADR0298/v2.55.0 is evidence only and collides with the current serialized allocation. Allocate the then-live collision-free ADR/release identity only during reconstruction on exact repaired #833, and keep the decision Proposed while Draft.
Closed #834 is a competing historical implementation of the same residual buyer gap. Its closed state is valid only if the reconstructed successor proves complete inheritance of every valid source/test/fixture/contract/evidence delta. Before treating #834 as fully superseded, compare it against the rebuilt #835; if any valid delta is missing, reopen it or preserve the missing delta through an explicit successor under the no-drop rule. Do not duplicate the stale implementation merely because it is closed.
Product/accessibility invariants
R; never derive it fromY-E,U,R̂, geometry, reconstruction, shares, rank, coverage, pair count, or unused axes.Romits only the residual metric; finite zero and negative values remain explicit and unclamped.Keep Draft until exact repaired #833 exists, this residual delta is reconstructed non-force, realistic current-parent RED → minimum causal repair → exact-head backend/frontend/security GREEN is complete, rendered responsive/pointer/touch/keyboard/focus/a11y evidence and canonical translation-ledger consumption are current, applicable authenticated PostgreSQL/k6 evidence exists, and qualifying independent approval/governance conditions are satisfied. No self-approval, bypass, force-push, destructive rebase, ancestor skip, stale-head evidence transfer, or gate weakening.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.