feat(reports): leftover-map axis share on leftover-map graphic leftover-map axis ticks independently of leftover-map singular values (v2.89.0) - #873
Conversation
…er-map axis ticks independently of leftover-map singular values (v2.89.0) Caption leftover-map graphic leftover-map axis ticks with persisted leftover-map axis share through leftoverMapPlotTickAxisBadge independently of leftover-map singular values (ADR 0332). Share and σ omit independently. Rank-0 unused axes still name leftover-map axis share 0%. Leftover-map comparison leftover-axis ticks and leftover-axis ticks stay σ-only. Do not invent leftover-map axis share from σ_k. Do not invent σ_k from leftover-map axis share. Never invent a leftover score or a theta. No new columns.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Leave open for independent APPROVE. Do not self-approve. Frontend lint and leftover-map + App tests are green (677 passed, oxlint 0, tsc -b). After independent review, retarget onto leftover-coordinates rather than squash-merging onto the leftover base. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| leftoverShare?: number | null, | ||
| ): LeftoverMapCompareAxisBadge { | ||
| const singular = formatLeftoverMapPlotAxisSingular(leftoverSingular); | ||
| if (singular === null) { | ||
| const percent = formatLeftoverMapPlotAxisShare(leftoverShare); | ||
| if (singular === null && percent === null) { |
There was a problem hiding this comment.
📝 Info: Existing callers preserve old labels
An omitted leftoverShare formats as null. Existing three-argument calls therefore retain coordinate-only or singular-only labels.
Was this helpful? React with 👍 or 👎 to provide feedback.
| ); | ||
| return tf(badge.key, badge.values); | ||
| } | ||
| const badge = leftoverMapPlotTickAxisBadge(axisIndex, tickLabel, leftoverSingular); | ||
| const badge = leftoverMapPlotTickAxisBadge(axisIndex, tickLabel, leftoverSingular, leftoverShare); |
There was a problem hiding this comment.
📝 Info: Comparison labels remain isolated
The comparison branch still uses leftoverMapComparePlotTickAxisBadge. Only report plots pass the share into leftoverMapPlotTickAxisBadge.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
| const singular = formatLeftoverMapPlotAxisSingular(leftoverSingular); | ||
| if (singular === null) { | ||
| const percent = formatLeftoverMapPlotAxisShare(leftoverShare); | ||
| if (singular === null && percent === null) { | ||
| return { key: LEFTOVER_MAP_PLOT_TICK, values: { axis: axisIndex, value: tickLabel } }; | ||
| } | ||
| if (singular === null && percent !== null) { | ||
| return { | ||
| key: LEFTOVER_MAP_PLOT_TICK_SHARE, | ||
| values: { axis: axisIndex, value: tickLabel, share: percent }, |
There was a problem hiding this comment.
📝 Info: Zero share remains visible
The shared formatter rejects only null and non-finite values. A persisted zero therefore renders as 0% instead of disappearing.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Cycle 2026-08-31T05:35Z: writes retry on #873. Devin's three notes (omitted leftoverShare keeps 3-arg σ-only labels; comparison ticks stay leftoverMapComparePlotTickAxisBadge; rank-0 share 0% remains visible) match ADR 0332 and are not defects. Independent APPROVE still required. Do not self-approve. Do not squash leftover stack onto unprotected leftover base. Next stacked increment is leftover-map comparison leftover-axis ticks with leftover-map axis share independently of leftover-map singular values (leftoverMapCompareAxisTickBadge, v2.90.0 / ADR 0333) onto this head. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Leave open for independent APPROVE. Do not self-approve. Devin infos match ADR 0332 (share omits independently; comparison ticks stay on leftoverMapComparePlotTickAxisBadge; rank-0 share 0% remains). After independent review, retarget onto leftover-coordinates rather than squash-merging onto the leftover base. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE.
|
Cycle 2026-08-31 14:40 KST: leftover-map graphic leftover-map axis tick leftover-map axis share (ADR 0332 / v2.89.0) remains MERGEABLE at 923bcfe with Frontend lint SUCCESS and Full test suite SUCCESS. Independent APPROVE still required. Do not self-approve. Do not squash-merge. #874 (v2.90.0) is stacked on this head. Issues #79 and #87 stay open. Do not merge #808. |
|
Cycle 2026-08-31 15:24 KST: leave open for independent APPROVE. Devin COMMENT is not independent APPROVE. Do not self-approve. Do not squash-merge. Stacked #874 (ADR 0333) remains MERGEABLE at ba58c21. Next increment ADR 0334 names leftover-axis ticks leftover-map axis share as leftoverMapAxisTickBadge independently of leftover-map singular values. Issues #79 and #87 stay open. |
|
Cycle note (2026-08-31 15:24 KST): stacked leftover-map PRs stay open. #874 (v2.90.0 / ADR 0333) is green with Devin COMMENT only — not independent APPROVE. Next increment ADR 0334 leftover-axis ticks leftover-map axis share as leftoverMapAxisTickBadge stacks onto #874. Do not self-approve. Do not squash-merge. |
seonghobae
added
enhancement
ChatGPT Codex Connector
Adopt exact reconstructed #872 as the repaired tree while preserving historical #873 as first parent. Retain v2.89 intent as an executable RED only: report-graphic ticks must expose persisted axis share independently of singular evidence, preserve finite zero, omit invalid evidence, and never infer share from singular values. No force update or stale source replay.
Adopt exact reconstructed #873 as the repaired tree while preserving historical #874 as first parent. Retain v2.90 intent as an executable RED only: comparison-strip ticks must expose persisted axis share independently of singular evidence, preserve finite zero, omit invalid evidence, and never infer share from singular values. No force update or stale source replay.
1 participant
Summary
leftoverMapPlotTickAxisBadgeindependently of persisted singular-value evidence (ADR 0332 / v2.89.0).σ_k; missing/non-finite share omits only share. Rank-0 unused axes retain0%.σ_korσ_kfrom share. UI-only; no SQL or new columns; never invent a leftover score or theta.Current exact authority
c87b2400470afe5e8105dc1bd79d8736ac6f7fd858c5fa6c7d82e1cde9d2e886a5817e9f8319716058c5fa6...is an ordinary non-force adoption of repaired feat(reports): leftover-map axis share on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map singular values (v2.88.0) #872 ancestry; it also carries the inherited feat(reports): leftover-map distance on grouping comparison graphic (v2.76.0) #859 localized comparison-distance production/contract delta. Pre-convergence validation receipts do not transfer.Preserved local delta
leftoverMapPlotAxisSingular.test.ts: finite/rank-0 share, independent σ omission, invalid share omission, and comparison-tick distinctness.LeftoverMapPlot.test.tsxandApp.test.tsx: report-graphic tick share while comparison graphics remain distinct.i18n.test.ts: ko/zh/ja/vi share and singular-share tick keys.The inherited #859 consumer-test RED remains unresolved on this ancestry: comparison-only distance assertions in
LeftoverMapPlot.test.tsxstill demand the report accessible name while production intentionally composes the localized comparison-graphic and generic distance labels. Do not revert the localized production name or introduce a comparison-only static translation key.Fresh exact-head repository/security/browser-a11y/performance evidence plus qualifying independent approval remain required before promotion. No self-approval, bypass, force-push, destructive rebase, stale feature-branch retarget, or stale-evidence transfer.