refactor(operator): name bounded entry points and validate Keyman admissions - #919
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Scheduled review-feedback autofix for this PR head.
|
seonghobae
left a comment
There was a problem hiding this comment.
Parent #899 moved non-force to e5711282…; this branch is now mechanically conflicting only because it still embeds the pre-#931 workflow contract. Its 14 bounded-operator files are disjoint from the parent’s four workflow/contract repairs. Preserve the operator delta exactly, adopt those protected blobs, and advance with a two-parent non-force convergence commit. This is a wrong-base repair; predecessor checks/reviews do not transfer.
Purpose
Repair verified LineageWeave-owned generic operator naming defects, make the post-Keyman backfill genuinely bounded, and keep model-backed work on the published contextual-orchestrator consumer boundary. Provider credentials/endpoints, model selection, routing and fallback remain outside LineageWeave.
RED → GREEN lineage
7b4b5046aa136943124df965ba0cb630f8238b9c→76335b36e68c5f42b46538c81d57e39b0b54599a;b8897a282e884b2e3420141db4c71c247153df8f→6fa817f9253b5f23acf00b7967bfc8a19cb161d4;0247bf38dcfc4ab7131694d864d4180d458c2916→b83abd7ad3fb12392e7782106a8fbeaaa68cb55d;e15c43f31ce21e42fb95757a773e577ef0336d34→36d514b59e8b45dc84bcae0e1b2bfdb9ee3bf08a, plus overflow-totalityd047a869b471363b435410a8f8919bd51bebcb2b→5b49b923751cb1cae18a0e70ad94afbedff93e12;c3bf8505a8de0a2dca80ecf7f510abe7035e2602→ab7807b890c349cbe5550e3637a97bfc50751d0a,f2ddd8372b4f0d6026cb6a19186a491ac87f86e7→fc757f1a37cf13a3b361b40b75ea16515fdbff30,21223c10dfd39f3833c2ba7d736c246d8231c156→d0c0a05beff0a89493ce9057b5b4c1d53012bab1;25ca75981659d1a8ff8c3a462e45978646769c3a→23387d7531de4d2cc5dcce46dd3d06b2a6f26e54,aace26ff5d870e98b51defed678384d32f014006→e9934ba08398d222098dfc14ccd768343c0e6902, upper boundcf97ac5ac5e8b5b5ee1534e7d9c50e594dcf2364→ab769da595b907aa61ba4b068fc35ca02e8b3097;4a22ed3bfa4fa5edefa8146a22f3f4f95b1714a5→75aefd7b9f3f987d4d2dd75eaa1c142e65b80ecb;78f1633e96dbafc6f60ded80a80951aac3f3391e→0f1f7f003700d43c8595117701e7b45b507b40e6, with756f321d3493179776bfaa3da022c05fcb7c14ffand63b292337f50c5b5127b7f778d4cb2404cae75accarrying the admitted timeout to HTTP work;61d94c3afdeadc3634785181d6b40a1f55d50b23→fa109e6fb117c985624310d2230dd779287d9b3d; non-default limits require explicit--all, and explicit post selection cannot be combined with batch mode. ADR 0082 is current at933d28b99122daf8297108be4db2b65c474f7f3e, changelog at39a4803e2e282a34e5f284a4815933c749196bb9.Boundary / migration safety
The behavior remains LineageWeave-owned operator policy. Keyman and Vision consume contextual-orchestrator only through the released consumer boundary; schema, report keys, persistence semantics, transaction behavior and idempotent ingestion stay unchanged. Inputs fail before client creation/database access rather than being silently normalized or collapsed.
Current stack / merge boundary
Parent #899 moved non-force to
e5711282c48cc20d0a88fb56a9e382d500989c72after adopting protectedmain@83eba56149eb802cd63642c507c324c9976ec78e. Review5118124470verified this PR's 14 bounded-operator files do not overlap the four inherited workflow/contract repairs. Two-parent convergencecaf8ee0f576eb23dc80d907fccfdcd6a4cecb232preserves the bounded-operator tree, adopts the exact protected workflow contract, and joins the moved #899 parent without force rewrite.#899@e5711282c48cc20d0a88fb56a9e382d500989c72;caf8ee0f576eb23dc80d907fccfdcd6a4cecb232;33923125661completedskippedunder Draft admission and is not product GREEN;Keep Draft until the unchanged current head is eligible for full exact-head required evidence and a qualifying independent review. No self-approval, force-push, destructive rebase, bypass, or gate weakening.