fix(validation): preserve representable recovery metrics - #488
fix(validation): preserve representable recovery metrics#488seonghobae wants to merge 802 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Exact-head repair finding — normalized radicand finiteness is unreachableFresh exact-head review of The source-order invariant is sufficient to remove that predicate while retaining the following
Chosen repair: remove only let normalized_radicand = normalized_square_sum - normalized_cross_product;
- if !normalized_radicand.is_finite()
- || subtraction_roundoff(
- normalized_square_sum,
- normalized_cross_product,
- normalized_radicand,
- ) != 0.0
- {
+ // The admitted normalized square sum has magnitude below 8 and the
+ // normalized cross-product below 4, so this subtraction is finite. Keep the
+ // error-free subtraction proof as the actual exact-admission boundary.
+ if subtraction_roundoff(
+ normalized_square_sum,
+ normalized_cross_product,
+ normalized_radicand,
+ ) != 0.0
+ {
return Ok(None);
}Do not change formulae, route order, coverage denominator, tests, or fallback behavior. Not chosen: removing or forcing coverage of the preceding normalized cross-product FMA predicate Acceptance for the source repair remains exact-head only: rustfmt/Clippy/no-retry tests/doctest/rustdoc/dependency policy, repository/Python and Live PostgreSQL must stay GREEN, and unique-source branch coverage must show denominator-honest removal of one two-outcome predicate with missing coverage decreasing by one. Predecessor artifacts are not transferable evidence. |
|
Exact-head source repair pushed as The diff is intentionally limited to
|
|
Predecessor repair Immutable branch artifact The next exact head is now |
|
Exact-head evidence for Immutable branch artifact Fresh source-order review identifies the next repair candidate in |
|
2026-09-10 exact-head repair evidence Live #488 head is Predecessor The first candidate Current Exact-head verification is now complete. Documentation Quality Fresh review enumeration has COMMENTED submissions only and zero inline review threads. Ruleset |
|
Coverage RED candidate on exact head The represented sample is This candidate intentionally tests the earlier unresolved subnormal-FMA concern rather than deleting the predicate. Current workflows |
|
Exact-head repair note (2026-09-10): predecessor Current head Documentation Quality |
|
Exact-head follow-up on Witness: with This targets the currently missing general translated-path false-zero predicate around current |
Validation Evidence authority
#488 remains the owner-correct Validation Evidence landing vehicle, stacked on prerequisite
#492@794ba9e6dda9f043aa499920fdf609b81b075d7e; protected release authority remainsmain@a243f18da4a4ca8a8d068c39922537f1f8ed6ad0. Current exact head isc74b7998adf19ea4bcc266726fdeb2f0bab4ed4a. The PR stays Draft/open/mergeable. No force update, destructive rebase, self-approval, gate weakening, coverage exclusion, mutable sibling dependency, or copied provider/scientific-owner logic is used.Production
validation_core::bias_standard_errorkeeps bounded represented-input exact admission forn=3..=16;n=2retains its cheaper exact identity andn>16remains characterization-only under #491. Reusable generalized psychometric arithmetic remains fast-mlsirm-owned.Current exact-head evidence
c74b7998adf19ea4bcc266726fdeb2f0bab4ed4acompleted Documentation Quality34439763859GREEN. Rust Foundation34439763776completed RED only at authored production line/branch coverage. Repository/Python contracts plus SBOM/provenance, Live PostgreSQL, rustfmt, Clippy, no-retry tests, doctests, warning-free rustdoc, and dependency/license/advisory/source policy are GREEN on this exact head.Immutable branch artifact
10137604460(sha256:1e5dbc11a6f606a6db8f9d86099de0d59dc29de28a8e1b6261cfa7235a59d8f7) folds under the checked-incrates/*/src/*unique-source/max rule to 4,458/4,480, 22 missing arms, all incrates/validation_core/src/bias.rs. Immutable line artifact10137570220(sha256:c745f4119fda6c07c3907e78a68b46a3a24e145e1c2f7b3fc164ab92cafa04dc) keeps the authored-line gate RED. The predecessorc1c136d...was4,459/4,482, 23 missing; the source-invariant repair therefore produced the exact denominator-honest delta expected: total-2, covered-1, missing-1.c74b7998...removes only the unreachable three-level call-site branch aroundexact_subnormal_rational_scale(exact_root, 1, 3). Reaching that direct path proves a positive exactly represented binary64 radicand and an exactly represented root. Any positive represented radicand is at least2^-1074, henceexact_root >= 2^-537; dividing that root by 3 remains vastly above minimum normal2^-1022. The shared helper remains intact for the genuinely reachable two-level rational-scale subnormal path.Coverage attribution corrections retained
The retained
bias_two_level_non_square_count_factor_contract.rsis useful ordinaryn=4regression evidence but did not reduce the branch frontier. Exact source mapping shows missing coordinate(145,12)-(145,44)is specificallydenominator > usize::MAX as u128; the preceding non-square numerator/denominator predicates were already exercised.Likewise the retained minimum-subnormal normalized-three-level regression is valid false-zero/permutation evidence, but missing
(340,15)-(340,42)maps to!standard_error.is_finite(), notstandard_error.is_subnormal(). The subnormal admission-refusal branch itself is already exercised. Coverage coordinates are assigned meaning only after mapping against the exact source head.Next causal source frontier
On
c74b7998..., normalized three-level admission givesmax(|a|,|b|) in [1,2)after exact power-of-two scaling. The positive-definite quadratica²+b²-abis therefore at least3/4and below12, so the correctly rounded normalizedsqrt(radicand)/3is positive finite and strictly below2/sqrt(3). The scale is a finite power of two no larger than2^1023; multiplication by a positive factor below1.155therefore cannot overflow binary64. Consequently!standard_error.is_finite()at the normalized three-level tail is structurally unreachable. A minimal follow-up may remove only that non-finite predicate while retaining the separate false-zero guard until its subnormal-grid lower bound is independently proved.The line-145
denominator > usize::MAXpredicate is not removed yet. Its reachability depends on the supported target integer width; current 64-bit runners make it redundant after theu128bounds, but repository support for narrower targets must be resolved before source deletion.General translated-path dispersion and final-result guards require analogous upstream-bound proofs rather than manufactured payloads.
Review / foundation / release boundary
Fresh review enumeration has historical
COMMENTEDsubmissions only and zero inline review threads; no qualifying current-head approval exists. Organization ruleset18156473requires one approving review, stale-review dismissal after push, review-thread resolution, central required workflows, and non-fast-forward protection.#492 remains Draft/open/mergeable at exact
794ba9e6dda9f043aa499920fdf609b81b075d7e, stacked on protectedmain@a243f18da4a4ca8a8d068c39922537f1f8ed6ad0. TEPP and contextual-orchestrator currently expose no GitHub release; TEPP does not copy unpublished provider routing/credentials/model selection or consume mutable contextual-orchestrator source as production authority.Before protected merge or any
n>16activation, require one exact current head with owned-production 100% authored line+branch coverage, current security/documentation/review gates, truthful route telemetry, release CPU/allocator/RSS evidence, code-current TRACEABILITY/product-technical-gap authority, and qualifying independent review.