Fix MATLAB retry loop hang and crashes in concore_read.m #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@pradeeban Hey again, the test failures aren't related to this change. This PR only modifies concore_read.m (MATLAB file) , thankss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retry loop in concore_read.m had no max retry limit and no error handling around file operations. If a file stayed empty or fopen failed during retries, the loop would either hang forever or crash the whole function.
Added a 5-retry cap (matching the Python implementation) and wrapped the retry loop body in try-catch to handle file errors gracefully. Falls back to the default value if retries are exhausted.
Fixes #239