Skip to content

Add extension point for custom ibc port name#1710

Draft
alpe wants to merge 2 commits intomainfrom
1707_ibcport
Draft

Add extension point for custom ibc port name#1710
alpe wants to merge 2 commits intomainfrom
1707_ibcport

Conversation

@alpe
Copy link
Copy Markdown
Contributor

@alpe alpe commented Nov 10, 2023

🚧 early version

Resolves #1707

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 13, 2023

Codecov Report

Merging #1710 (88ae8da) into main (4313d7f) will decrease coverage by 0.06%.
The diff coverage is 77.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1710      +/-   ##
==========================================
- Coverage   57.43%   57.37%   -0.06%     
==========================================
  Files          62       62              
  Lines        8145     8158      +13     
==========================================
+ Hits         4678     4681       +3     
- Misses       3030     3039       +9     
- Partials      437      438       +1     
Files Coverage Δ
x/wasm/ibc.go 68.71% <100.00%> (ø)
x/wasm/keeper/handler_plugin.go 81.18% <100.00%> (ø)
x/wasm/keeper/handler_plugin_encoders.go 80.89% <100.00%> (ø)
x/wasm/keeper/keeper_cgo.go 94.28% <100.00%> (+0.16%) ⬆️
x/wasm/keeper/options.go 82.45% <100.00%> (+0.63%) ⬆️
x/wasm/keeper/keeper.go 79.52% <50.00%> (-0.50%) ⬇️
x/wasm/keeper/ibc.go 58.33% <40.00%> (-19.45%) ⬇️

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 3, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 77.14286% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.37%. Comparing base (4313d7f) to head (88ae8da).
⚠️ Report is 719 commits behind head on main.

Files with missing lines Patch % Lines
x/wasm/keeper/ibc.go 40.00% 6 Missing ⚠️
x/wasm/keeper/keeper.go 50.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1710      +/-   ##
==========================================
- Coverage   57.43%   57.37%   -0.06%     
==========================================
  Files          62       62              
  Lines        8145     8158      +13     
==========================================
+ Hits         4678     4681       +3     
- Misses       3030     3039       +9     
- Partials      437      438       +1     
Files with missing lines Coverage Δ
x/wasm/ibc.go 68.71% <100.00%> (ø)
x/wasm/keeper/handler_plugin.go 81.18% <100.00%> (ø)
x/wasm/keeper/handler_plugin_encoders.go 80.89% <100.00%> (ø)
x/wasm/keeper/keeper_cgo.go 94.28% <100.00%> (+0.16%) ⬆️
x/wasm/keeper/options.go 82.45% <100.00%> (+0.63%) ⬆️
x/wasm/keeper/keeper.go 79.52% <50.00%> (-0.50%) ⬇️
x/wasm/keeper/ibc.go 58.33% <40.00%> (-19.45%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IBC port id creation is not compatible with Bech32 characters space

2 participants