Skip to content

Fix null reference in ChipGroup, empty catch block in SingleLineInputField, hardcoded color in FloatingNavigationButton #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix null reference in ChipGroup, empty catch block in SingleLineInputField, hardcoded color in FloatingNavigationButton #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7508693
Initial plan
Copilot Feb 27, 2026
7fe26bb
Fix null reference in ChipGroup, add error logging in SingleLineInput…
Copilot Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## [55.2.3]
- [ChipGroup] Fixed potential null reference when selected items don't match chip items.
- [SingleLineInputField] Added error logging to Focus method instead of silently swallowing exceptions.
- [FloatingNavigationButton] Replaced hardcoded color with design token `color_fill_highlight`.

## [55.2.2]
- [iOS26][Tip] Added more padding.

Expand Down
10 changes: 6 additions & 4 deletions src/library/DIPS.Mobile.UI/Components/ChipGroup/ChipGroup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ private void SetChipsToggledBasedOnSelectedItems()
if (selectedItem is not null)
{
var chipItem = m_chipItems.FirstOrDefault(chipItem => chipItem.Obj.GetPropertyValue(ItemDisplayProperty)!.Equals(selectedItem.GetPropertyValue(ItemDisplayProperty)));
chipItem!.Chip.IsToggled = true;
ChipToggled(chipItem!, false);
if (chipItem is null) return;
chipItem.Chip.IsToggled = true;
ChipToggled(chipItem, false);
}
}
else
Expand All @@ -58,8 +59,9 @@ private void SetChipsToggledBasedOnSelectedItems()
selectedItemList.ForEach(item =>
{
var chipItem = m_chipItems.FirstOrDefault(chipItem => chipItem.Obj.GetPropertyValue(ItemDisplayProperty)!.Equals(item.GetPropertyValue(ItemDisplayProperty)));
chipItem!.Chip.IsToggled = true;
ChipToggled(chipItem!, false);
if (chipItem is null) return;
chipItem.Chip.IsToggled = true;
ChipToggled(chipItem, false);
});
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...DIPS.Mobile.UI/Components/Navigation/FloatingNavigationButton/FloatingNavigationButton.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace DIPS.Mobile.UI.Components.Navigation.FloatingNavigationButton;
internal class FloatingNavigationButton : Grid
{
private Color OpenedColor = Colors.GetColor(ColorName.color_fill_default);
private Color ClosedColor = Color.FromArgb("#BF8DCE");
private Color ClosedColor = Colors.GetColor(ColorName.color_fill_highlight);
private ImageSource OpenedIcon = Icons.GetIcon(IconName.close_line);
private ImageSource ClosedIcon = Icons.GetIcon(IconName.menu_line);
private readonly FloatingNavigationButtonConfigurator m_floatingNavigationButtonConfigurator;
Expand Down Expand Up @@ -132,7 +132,7 @@ public View CreateAnimateableButton()
{
DUI.EnsureSkLottieResourcesAdded();

var closedColor = Color.FromArgb("#BF8DCE");
var closedColor = Colors.GetColor(ColorName.color_fill_highlight);
var button = new Border()
{
HeightRequest = Sizes.GetSize(SizeName.size_15),
Expand Down
3 changes: 2 additions & 1 deletion src/library/DIPS.Mobile.UI/Components/TextFields/InputFields/SingleLineInputField.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using DIPS.Mobile.UI.Effects.Touch;
using DIPS.Mobile.UI.Formatters;
using DIPS.Mobile.UI.Internal;
using DIPS.Mobile.UI.Internal.Logging;
using DIPS.Mobile.UI.Resources.LocalizedStrings.LocalizedStrings;
using DIPS.Mobile.UI.Resources.Styles;
using DIPS.Mobile.UI.Resources.Styles.InputField;
Expand Down Expand Up @@ -298,7 +299,7 @@ private void UpdateInputViewVisibility()
}
catch (Exception e)
{

DUILogService.LogError<SingleLineInputField>($"Focus failed: {e.Message}");
}
}

Expand Down