Skip to content

[SearchPage][Android] Fix bug where ScrollableHeader were not added. #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vetle444 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[SearchPage][Android] Fix bug where ScrollableHeader were not added. #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfb74fb
fix
Vetle444 Mar 17, 2026
28bd5b2
cleanup
Vetle444 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## [55.3.1]
- [SearchPage][Android] Fix bug where `ScrollableHeader` were not added.

## [55.3.0]
- [SearchPage] Added `ScrollableHeader` property to allow consumers to provide a header that scrolls with search results.
- [SearchPage] Replaced `OnLoaded`/`OnUnloaded` event subscriptions with `OnHandlerChanged` override.
Expand Down
4 changes: 3 additions & 1 deletion src/library/DIPS.Mobile.UI/Components/Searching/SearchPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ public SearchPage()
AutomationId = "ResultCollectionView".ToDUIAutomationId<SearchPage>(),
HeaderTemplate = new DataTemplate(() => new Grid { Padding = new Thickness(0, Sizes.GetSize(SizeName.content_margin_large), 0, 0) })
};

m_resultCollectionView.SetBinding(StructuredItemsView.HeaderProperty, static (SearchPage searchPage) => searchPage.BindingContext, source: this);

m_resultCollectionView.Scrolled += OnCollectionViewScrolled;
m_resultCollectionView.SetBinding(ItemsView.ItemTemplateProperty, static (SearchPage searchPage) => searchPage.ResultItemTemplate, source: this);
Expand Down Expand Up @@ -258,7 +260,7 @@ private void OnSearchModeChanged()

private void OnScrollableHeaderChanged()
{
m_resultCollectionView.Header = ScrollableHeader;
m_resultCollectionView.HeaderTemplate = new DataTemplate(() => ScrollableHeader);
}
Comment on lines 261 to 264

private void OnFooterViewChanged()
Expand Down
Loading