fix(rss): restore CEs in getSiteElements#8480
Merged
fstagni merged 1 commit intoDIRACGrid:integrationfrom Mar 11, 2026
Merged
Conversation
fstagni
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CSHelpers.getSiteElements() to include ComputingElements alongside StorageElements when determining elements belonging to a site
Problem:
After #8446 (removal of node/queue tables), getSiteElements() was left returning only StorageElements for a given site. This broke the PropagationCommand, which determines site status by checking if any element belonging to a site is
Active.Sites that have no StorageElements (only ComputingElements) now get an empty element list, causing propagationCommand.doCache() to fall through to the default
Bannedstatus with reason "There is no Active element in the site ###".This is what caused the mass banning of sites in LHCb.
Fix:
getSiteElements() now also queries getCESiteMapping() to include CEs for the site. The original code (before #8446) included both SEs and queues — removing queues was correct, but CEs should have been preserved. If the CE mapping call fails, it is handled gracefully (SEs are still returned).
BEGINRELEASENOTES
*ResourceStatus
FIX: restore CEs in getSiteElements
ENDRELEASENOTES