[Feature Request]: Add Missing PGSQL Functions

[elliothomerwilkinson]

Topic

Support new SQL

Description

The PostgreSqlLexer.g4 is missing support for common Postgres functions TO_CHAR and DATE_TRUNC

Please can these be added.

This is an issue since basic postgres sql like below is marked as invalid:

SELECT
    TO_CHAR(DATE_TRUNC('week', "my_date"), 'YYYY-MM-DD') as x
FROM test_table;

[LuckyFBB]

We will check and make improvements.

[liuxy0551]

Thanks for the report.

We rechecked the provided SQL on the current version, and PostgreSQL.validate() returns no errors. The query is supported in v4.4.0 and later.

The original validation failure was not caused by missing TO_CHAR or DATE_TRUNC lexer tokens. Both are ordinary PostgreSQL function names and are parsed through the generic functionName -> identifier rule. The actual issue was a conflicting qualifiedName alternative in primaryExpression, which was fixed by #435 as part of #432.

We do not plan to add KW_TO_CHAR or KW_DATE_TRUNC. Hardcoding ordinary functions as lexer keywords would not scale to PostgreSQL built-in functions, extension functions, or user-defined functions.

For code completion, ordinary functions currently produce a generic function syntax candidate. Concrete function names should be supplied by a function catalog on the consumer side. A library-level function catalog could be discussed in a separate feature request.

Since the reported SQL now validates correctly, we will close this issue. If it still fails with dt-sql-parser >= 4.4.0, please provide the exact package version and validation output.

[Cythia828]

已解决，关闭