Respect GL_MAX_UNIFORM_BLOCK_SIZE for dlights buffer#1969
Open
slipher wants to merge 1 commit intoDaemonEngine:masterfrom
Open
Respect GL_MAX_UNIFORM_BLOCK_SIZE for dlights buffer#1969slipher wants to merge 1 commit intoDaemonEngine:masterfrom
slipher wants to merge 1 commit intoDaemonEngine:masterfrom
Conversation
Member
|
Side note: we haven't fixed it yet, but when you open a PR with a branch from a GitHub fork, it doesn't run Azure CI anymore. |
Member
Author
|
OK I fixed it. Now I just need to delete the duplicate version of the pipeline :) |
Member
|
Nice! |
Member
Author
|
It was this ("Require a team member's comment"). It's an organization-scope setting so it ought to be fixed too for Crunch and any other repos we have. 
|
Member
|
I had also tested that… but it didn't work. Weird. Anyway, thanks for having fixed it! |
Member
|
This doesn't fix the realtime lights on ZX C-1190. |
illwieckz
approved these changes
May 8, 2026
Member
illwieckz
left a comment
illwieckz
left a comment
There was a problem hiding this comment.
Anyway, more fixes are welcome, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.