Repository navigation
Conversation
… needed for cross-compilation
illwieckz
changed the title
illwieckz
changed the title
slipher
reviewed
Oct 10, 2026
slipher
left a comment
slipher
left a comment
Member
There was a problem hiding this comment.
LGTM to:
external_deps: make possible to loop the cmake buildexternal_deps: deduplicate nacl from pnacl copy code
Apparently we already had ostensible support for configuring the platform more than once (the PLATFORM_LIST thing), but I guess there must have been some gaps. Anyway the platform reconfiguration/native package series looks pretty good, just some nits.
| BUILD_DIR="${WORK_DIR}/${BUILD_BASEDIR}" | ||
| PREFIX="${BUILD_DIR}/prefix" | ||
| PATH="${PREFIX}/bin:${PATH}" | ||
| PLATFORM_SYSTEM="$(echo "${PLATFORM}" | cut -f1 -d-)" |
| common_setup_native() { | ||
| case "$(uname -s)" in | ||
| CYGWIN_NT-*|MSYS_NT-*|MINGW*_NT-*) | ||
| EXE_EXT='.exe' |
Member
There was a problem hiding this comment.
We already removed any attempts at MSYS support so this seems out of place.
| setup_platform() { | ||
| case "${1}" in | ||
| native) | ||
| export PLATFORM='native-native-native' |
Member
There was a problem hiding this comment.
I don't think you want to export this
| } | ||
|
|
||
| # Set up environment for native host tools | ||
| setup_native() { |
Member
There was a problem hiding this comment.
How about putting PLATFORM=native-native-native here? Then you can remove the whole setup_platform function.
| fi | ||
| } | ||
|
|
||
| dedupe_dir () |
Member
There was a problem hiding this comment.
What's an example of duplicates that we have?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging more stuff from:
First rounds were:
This doesn't bump the deps version.
jdupesorrdfind. We can settle onjdupesif that's preferred. If none of those tools are present files are stored as normal files. Symlink dereference is still done but now done before the hardlink creation.linux-amd64andlinux-armhfwhen building deps forlinux-arm64(not implemented in that PR). This may also make possible to build the same software as a native tool and to rebuild it for the target if needed.nativeplatform and building native tools in a special prefix that doesn't contribute to the target package.pkg-configandnasmas native tools.