Skip to content

Migrate to native GitHub issue priorities (#8044)#8076

Open
nadove-ucsc wants to merge 4 commits into
developfrom
issues/nadove-ucsc/8044-migrate-to-native-gh-issue-priorities
Open

Migrate to native GitHub issue priorities (#8044)#8076
nadove-ucsc wants to merge 4 commits into
developfrom
issues/nadove-ucsc/8044-migrate-to-native-gh-issue-priorities

Conversation

@nadove-ucsc

@nadove-ucsc nadove-ucsc commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Linked issues: #8044

Checklist

Author

  • PR is assigned to the author
  • Status of PR is In progress
  • PR is a draft
  • Target branch is develop
  • Name of PR branch matches issues/<GitHub handle of author>/<issue#>-<slug>
  • PR is linked to all issues it (partially) resolves
  • Status of linked issues is In progress
  • PR description links to linked issues
  • PR title matches1 that of a linked issue or comment in PR explains why they're different
  • PR title references all linked issues
  • For each linked issue, there is at least one commit whose title references that issue

1 when the issue title describes a problem, the corresponding PR
title is Fix: followed by the issue title

Author (partiality)

  • Added p tag to titles of partial commits
  • This PR is labeled partial or completely resolves all linked issues
  • This PR partially resolves each of the linked issues or does not have the partial label

Author (reindex)

  • Added r tag to commit title or the changes introduced by this PR will not require reindexing of any deployment
  • This PR is labeled reindex:dev or the changes introduced by it will not require reindexing of dev
  • This PR is labeled reindex:anvildev or the changes introduced by it will not require reindexing of anvildev
  • This PR is labeled reindex:anvilprod or the changes introduced by it will not require reindexing of anvilprod
  • This PR is labeled reindex:prod or the changes introduced by it will not require reindexing of prod
  • This PR is labeled reindex:partial and its description documents the specific reindexing procedure for dev, anvildev, anvilprod and prod or requires a full reindex or carries none of the labels reindex:dev, reindex:anvildev, reindex:anvilprod and reindex:prod

Author (mirror)

  • This PR is labeled mirror:dev or the changes introduced by it will not require mirroring of dev
  • This PR is labeled mirror:anvildev or the changes introduced by it will not require mirroring of anvildev
  • This PR is labeled mirror:anvilprod or the changes introduced by it will not require mirroring of anvilprod
  • This PR is labeled mirror:prod or the changes introduced by it will not require mirroring of prod
  • This PR is labeled mirror:partial and its description documents the specific mirroring procedure for dev, anvildev, anvilprod and prod or requires a full mirroring or carries none of the labels mirror:dev, mirror:anvildev, mirror:anvilprod and mirror:prod

Author (API changes)

  • This PR and its linked issues are labeled API or this PR does not modify a REST API
  • Added a (A) tag to commit title for backwards (in)compatible changes or this PR does not modify a REST API
  • Updated REST API version number in app.py or this PR does not modify a REST API

Author (upgrading deployments)

  • Ran make docker_images.json and committed the resulting changes or this PR does not modify azul_docker_images, or any other variables referenced in the definition of that variable
  • Documented upgrading of deployments in UPGRADING.rst or this PR does not require upgrading deployments
  • Added u tag to commit title or this PR does not require upgrading deployments
  • This PR is labeled upgrade or does not require upgrading deployments
  • This PR is labeled deploy:shared or does not modify docker_images.json, and does not require deploying the shared component for any other reason
  • This PR is labeled deploy:gitlab or does not require deploying the gitlab component
  • This PR is labeled deploy:runner or does not require deploying the runner image

Author (hotfixes)

  • Added F tag to main commit title or this PR does not include permanent fix for a temporary hotfix
  • Reverted the temporary hotfixes for any linked issues or the none of the stable branches (anvilprod and prod) have temporary hotfixes for any of the issues linked to this PR

Author (before every review)

  • Rebased PR branch on develop, squashed fixups from prior reviews
  • Ran make requirements_update or this PR does not modify Dockerfile, environment, requirements*.txt, common.mk, Makefile or environment.boot
  • Added R tag to commit title or this PR does not modify requirements*.txt
  • This PR is labeled reqs or does not modify requirements*.txt
  • make integration_test passes in personal deployment or this PR does not modify functionality that could affect the IT outcome
  • PR is awaiting requested review from a peer
  • Status of PR is Review requested
  • PR is assigned to only the peer and the author

Peer reviewer (after approval)

Note that after requesting changes, the PR must be assigned to only the author.

  • Actually approved the PR
  • PR is not a draft
  • PR is awaiting requested review from system administrator
  • Status of PR is Review requested
  • PR is assigned to only the system administrator and the author

System administrator (after approval)

  • Actually approved the PR
  • Labeled linked issues as demo or no demo
  • Commented on linked issues about demo expectations or all linked issues are labeled no demo
  • Decided if PR can be labeled no sandbox
  • A comment to this PR details the completed security design review
  • PR title is appropriate as title of merge commit
  • N reviews label is accurate
  • Status of PR is Approved
  • PR is assigned to only the operator and the author

Operator

  • Checked reindex:… labels and r commit title tag
  • Checked mirror:… labels
  • Checked that demo expectations are clear or all linked issues are labeled no demo
  • Squashed PR branch and rebased onto develop
  • Sanity-checked history
  • Pushed PR branch to GitHub

Operator (deploy .shared and .gitlab components)

  • Ran _select dev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused or this PR is not labeled deploy:shared
  • Ran _select dev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply or this PR is not labeled deploy:gitlab
  • Ran _select anvildev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused or this PR is not labeled deploy:shared
  • Ran _select anvildev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply or this PR is not labeled deploy:gitlab
  • Checked the items in the next section or this PR is labeled deploy:gitlab
  • PR is assigned to only the system administrator and the author or this PR is not labeled deploy:gitlab

System administrator (post-deploy of .gitlab component)

  • Background migrations for dev.gitlab are complete or this PR is not labeled deploy:gitlab
  • Background migrations for anvildev.gitlab are complete or this PR is not labeled deploy:gitlab
  • PR is assigned to only the operator and the author

Operator (deploy runner image)

  • Ran _select dev.gitlab && make -C terraform/gitlab/runner or this PR is not labeled deploy:runner
  • Ran _select anvildev.gitlab && make -C terraform/gitlab/runner or this PR is not labeled deploy:runner

Operator (sandbox build)

  • Added sandbox label or PR is labeled no sandbox
  • Pushed PR branch to GitLab dev or PR is labeled no sandbox
  • Pushed PR branch to GitLab anvildev or PR is labeled no sandbox
  • Build passes in sandbox deployment or PR is labeled no sandbox
  • Build passes in anvilbox deployment or PR is labeled no sandbox
  • Reviewed build logs for anomalies in sandbox deployment or PR is labeled no sandbox
  • Reviewed build logs for anomalies in anvilbox deployment or PR is labeled no sandbox
  • Applied upgrade instructions from UPGRADING.rst to sandbox or this PR is not labeled upgrade, or upgrade instructions do not apply to sandbox
  • Applied upgrade instructions from UPGRADING.rst to anvilbox or this PR is not labeled upgrade, or upgrade instructions do not apply to anvilbox
  • Deleted unreferenced indices in sandbox or this PR does not remove catalogs or otherwise causes unreferenced indices in sandbox
  • Deleted unreferenced indices in anvilbox or this PR does not remove catalogs or otherwise causes unreferenced indices in anvilbox
  • Started reindex in sandbox or this PR is not labeled reindex:dev
  • Started reindex in anvilbox or this PR is not labeled reindex:anvildev
  • Checked for failures in sandbox or this PR is not labeled reindex:dev
  • Checked for failures in anvilbox or this PR is not labeled reindex:anvildev
  • Started mirroring in sandbox or this PR is not labeled mirror:dev
  • Started mirroring in anvilbox or this PR is not labeled mirror:anvildev
  • Checked for failures in sandbox or this PR is not labeled mirror:dev
  • Checked for failures in anvilbox or this PR is not labeled mirror:anvildev

Operator (merge the branch)

  • All status checks passed and the PR is mergeable
  • The title of the merge commit starts with the title of this PR
  • Added PR # reference to merge commit title
  • Collected commit title tags in merge commit title but only included p if the PR is also labeled partial
  • Pushed merge commit to GitHub
  • Status of PR is Merged lower
  • Status of blocked issues is Triage or no issues are blocked on the linked issues

Operator (main build)

  • Pushed merge commit to GitLab dev
  • Pushed merge commit to GitLab anvildev
  • Build passes on GitLab dev
  • Reviewed build logs for anomalies on GitLab dev
  • Build passes on GitLab anvildev
  • Reviewed build logs for anomalies on GitLab anvildev
  • Applied upgrade instructions from UPGRADING.rst to dev or this PR is not labeled upgrade, or upgrade instructions do not apply to dev
  • Applied upgrade instructions from UPGRADING.rst to anvildev or this PR is not labeled upgrade, or upgrade instructions do not apply to anvildev
  • Notified developers to apply upgrade instructions from UPGRADING.rst to their personal deployments or this PR is not labeled upgrade, or upgrade instructions do not apply to personal deployments
  • Ran _select dev.shared && make -C terraform/shared apply or this PR is not labeled deploy:shared
  • Ran _select anvildev.shared && make -C terraform/shared apply or this PR is not labeled deploy:shared
  • Deleted PR branch from GitHub
  • PR is assigned to only the operator
  • Deleted PR branch from GitLab dev
  • Deleted PR branch from GitLab anvildev
  • Status of linked issues is Lower, or Triage, if PR is partial
  • PR is assigned only to author

Author

  • Re-ran migration script and validated results
  • PR is assigned only to operator

Operator (reindex)

  • Deindexed all unreferenced catalogs in dev or this PR is neither labeled reindex:partial nor reindex:dev
  • Deindexed all unreferenced catalogs in anvildev or this PR is neither labeled reindex:partial nor reindex:anvildev
  • Deindexed specific sources in dev or this PR is neither labeled reindex:partial nor reindex:dev
  • Deindexed specific sources in anvildev or this PR is neither labeled reindex:partial nor reindex:anvildev
  • Indexed specific sources in dev or this PR is neither labeled reindex:partial nor reindex:dev
  • Indexed specific sources in anvildev or this PR is neither labeled reindex:partial nor reindex:anvildev
  • Started reindex in dev or this PR does not require reindexing dev
  • Started reindex in anvildev or this PR does not require reindexing anvildev
  • Checked for, triaged and possibly requeued messages in both fail queues in dev or this PR does not require reindexing dev
  • Checked for, triaged and possibly requeued messages in both fail queues in anvildev or this PR does not require reindexing anvildev
  • Emptied fail queues in dev or this PR does not require reindexing dev
  • Emptied fail queues in anvildev or this PR does not require reindexing anvildev
  • Restarted the Data Browser pipeline for the ucsc/hca/dev branch on GitLab in dev or this PR does not require reindexing dev
  • Restarted the Data Browser pipeline for the ucsc/lungmap/dev branch on GitLab in dev or this PR does not require reindexing dev
  • Restarted deploy_browser job in the GitLab pipeline for this PR in dev or this PR does not require reindexing dev
  • Restarted the Data Browser pipeline for the ucsc/anvil/anvildev branch on GitLab in anvildev or this PR does not require reindexing anvildev
  • Restarted deploy_browser job in the GitLab pipeline for this PR in anvildev or this PR does not require reindexing anvildev

Operator (mirroring)

  • Started mirroring in dev or this PR is not labelled mirror:dev
  • Started mirroring in anvildev or this PR is not labelled mirror:anvildev
  • Checked for, triaged and possibly requeued messages in mirror fail queue in dev or this PR is not labelled mirror:dev
  • Checked for, triaged and possibly requeued messages in mirror fail queue in anvildev or this PR is not labelled mirror:anvildev
  • Emptied mirror fail queue in dev or this PR is not labelled mirror:dev
  • Emptied mirror fail queue in anvildev or this PR is not labelled mirror:anvildev

Operator

  • Propagated the upgrade and API labels to the next promotion PRs or this PR carries neither of these labels
  • Propagated the deploy:shared, deploy:gitlab, deploy:runner, reindex:partial, reindex:anvilprod, reindex:prod, mirror:partial, mirror:anvilprod and mirror:prod labels to the next promotion PRs or this PR carries none of these labels
  • Propagated any specific instructions related to the deploy:shared, deploy:gitlab, deploy:runner, reindex:partial, reindex:anvilprod, reindex:prod, mirror:partial, mirror:anvilprod and mirror:prod labels, from the description of this PR to that of the next promotion PRs or this PR carries none of these labels
  • PR is assigned to no one

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@nadove-ucsc nadove-ucsc self-assigned this Jun 2, 2026
@nadove-ucsc nadove-ucsc linked an issue Jun 2, 2026 that may be closed by this pull request
@nadove-ucsc nadove-ucsc force-pushed the issues/nadove-ucsc/8044-migrate-to-native-gh-issue-priorities branch from 04669a6 to 7d6cc31 Compare June 2, 2026 19:31
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.72%. Comparing base (69bc7ef) to head (8cf8581).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8076   +/-   ##
========================================
  Coverage    84.72%   84.72%           
========================================
  Files          165      165           
  Lines        24252    24252           
========================================
  Hits         20547    20547           
  Misses        3705     3705           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coveralls

coveralls commented Jun 2, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 84.801%. remained the same — issues/nadove-ucsc/8044-migrate-to-native-gh-issue-priorities into develop

@nadove-ucsc

Copy link
Copy Markdown
Contributor Author

Tested with

diff --git a/.github/workflows/schedule.py b/.github/workflows/schedule.py
index b93086043..fcd3c3eb9 100644
--- a/.github/workflows/schedule.py
+++ b/.github/workflows/schedule.py
@@ -252,13 +252,9 @@ def main(args):
     now = datetime.now(tz)
     for template in Path('.github/ISSUE_TEMPLATE').glob('*.md'):
         self = IssueTemplate(path=template, dry_run=options.dry_run)
-        match self.is_eligible(now):
-            case None:
-                log.info('Ignoring issue template %s since it defines no schedule.', self.path)
-            case False:
-                log.info('Issue template %s is ineligible', self.path)
-            case True:
-                self.create_issue(now.date())
+        if self.is_eligible(now) is not None:
+            self.create_issue(now.date())
+            break
 
 
 if __name__ == '__main__':
$ GITHUB_REPO=DataBiosphere/azul-private python3 .github/workflows/schedule.py 
2026-06-03 12:23:09,962    INFO azul.github.schedule: Running ['gh', 'issue', 'list', '--repo=DataBiosphere/azul-private', '--search=in:title "Promotion 2026-06-03"', '--json=number', '--limit=10']
2026-06-03 12:23:10,654    INFO azul.github.schedule: Running ['gh', 'api', '--method', 'POST', '/repos/DataBiosphere/azul-private/issues', '-H', 'Accept: application/vnd.github+json', '-H', 'X-GitHub-Api-Version: 2022-11-28', '-f', 'title=Promotion 2026-06-03', '-f', 'body=- [ ] The title of this issue matches `Promotion yyyy-mm-dd`\n- [ ] For `prod`\n  - [ ] System administrator and operator determined the commit to be promoted\n  - [ ] Operator created the promotion PR\n- [ ] For `anvilprod`\n  - [ ] System administrator and operator determined the commit to be promoted\n  - [ ] Operator created the promotion PR\n- [ ] This issue is part of the sprint that includes the date from the issue title\n', '-f', 'type=Chore', '-f', 'labels[]=infra', '-f', 'labels[]=no demo', '-f', 'labels[]=operator']
2026-06-03 12:23:11,537    INFO azul.github.schedule: … created 'https://github.com/DataBiosphere/azul-private/issues/384', verifying labels and assignees …
2026-06-03 12:23:11,537    INFO azul.github.schedule: Successfully created and verified issue #384
2026-06-03 12:23:11,537    INFO azul.github.schedule: Running ['gh', 'api', '/orgs/DataBiosphere/issue-fields', '-H', 'X-GitHub-Api-Version: 2026-03-10']
2026-06-03 12:23:12,017    INFO azul.github.schedule: Running ['gh', 'api', '/repos/DataBiosphere/azul-private']
2026-06-03 12:23:12,612    INFO azul.github.schedule: Running ['gh', 'api', '--method', 'POST', '/repositories/539115215/issues/384/issue-field-values', '-H', 'X-GitHub-Api-Version: 2026-03-10', '--input', '-']
2026-06-03 12:23:13,590    INFO azul.github.schedule: Set native Priority='Medium' on issue #384 

https://github.com/DataBiosphere/azul-private/issues/384

@achave11-ucsc achave11-ucsc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

The changes, input: bytes | None = None, don't belong in the "Fix inaccurate return type annotation" commit.

Otherwise, OK

@achave11-ucsc achave11-ucsc removed their assignment Jun 4, 2026
@nadove-ucsc nadove-ucsc force-pushed the issues/nadove-ucsc/8044-migrate-to-native-gh-issue-priorities branch from 7d6cc31 to c8e5761 Compare June 4, 2026 00:56
@nadove-ucsc nadove-ucsc requested a review from achave11-ucsc June 4, 2026 01:10
@achave11-ucsc achave11-ucsc marked this pull request as ready for review June 4, 2026 01:26
achave11-ucsc
achave11-ucsc previously approved these changes Jun 4, 2026

@achave11-ucsc achave11-ucsc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ✅

@hannes-ucsc hannes-ucsc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Between you running the migration script and this getting merged, the schedule might have created issues without the new field. Please think the entire migration through and add any checklist items on this PR that might be necessary. I'd like you to take responsibility for the entire migration. Propose demo instructions on the issue.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't make this a drop! commit but add to attic instead. Also move zenhub_to_github.py to attic as well in a separate commit.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR checklist updated.

@hannes-ucsc hannes-ucsc added the 1 review [process] Lead requested changes once label Jun 4, 2026
@nadove-ucsc nadove-ucsc force-pushed the issues/nadove-ucsc/8044-migrate-to-native-gh-issue-priorities branch from c8e5761 to 75ededd Compare June 4, 2026 23:44
@nadove-ucsc nadove-ucsc force-pushed the issues/nadove-ucsc/8044-migrate-to-native-gh-issue-priorities branch from 75ededd to 8cf8581 Compare June 4, 2026 23:49
@nadove-ucsc nadove-ucsc requested a review from hannes-ucsc June 5, 2026 01:17
@hannes-ucsc

Copy link
Copy Markdown
Member

Security design review

  • Security design review completed; this PR does not
    • … affect authentication; for example:
      • OAuth 2.0 with the application (API or Swagger UI)
      • Authentication of developers with Google Cloud APIs
      • Authentication of developers with AWS APIs
      • Authentication with a GitLab instance in the system
      • Password and 2FA authentication with GitHub
      • API access token authentication with GitHub
      • Authentication with Terra
    • … affect the permissions of internal users like access to
      • Cloud resources on AWS and GCP
      • GitLab repositories, projects and groups, administration
      • an EC2 instance via SSH
      • GitHub issues, pull requests, commits, commit statuses, wikis, repositories, organizations
    • … affect the permissions of external users like access to
      • TDR snapshots
    • … affect permissions of service or bot accounts
      • Cloud resources on AWS and GCP
    • … affect audit logging in the system, like
      • adding, removing or changing a log message that represents an auditable event
      • changing the routing of log messages through the system
    • … affect monitoring of the system
    • … introduce a new software dependency like
      • Python packages on PYPI
      • Command-line utilities
      • Docker images
      • Terraform providers
    • … add an interface that exposes sensitive or confidential data at the security boundary
    • … affect the encryption of data at rest
    • … require persistence of sensitive or confidential data that might require encryption at rest
    • … require unencrypted transmission of data within the security boundary
    • … affect the network security layer; for example by
      • modifying, adding or removing firewall rules
      • modifying, adding or removing security groups
      • changing or adding a port a service, proxy or load balancer listens on
  • Documentation on any unchecked boxes is provided in comments below

@hannes-ucsc

Copy link
Copy Markdown
Member

Clearing the approved queue in preparation for the higher-priority #7794.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 review [process] Lead requested changes once

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to native GitHub issue priorities

5 participants