Skip to content

[OMG-1253] Add BDD test coverage for CreateTeamMembership #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NaOHman merged 1 commit into from
Mar 31, 2026
Merged

[OMG-1253] Add BDD test coverage for CreateTeamMembership #3181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cassettes/features/v2/teams/Add-a-user-to-a-team-returns-API-error-response-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2026-03-31T14:58:05.044Z
148 changes: 148 additions & 0 deletions cassettes/features/v2/teams/Add-a-user-to-a-team-returns-API-error-response-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ...ms/Add-a-user-to-a-team-returns-Represents-a-user-s-association-to-a-team-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2026-03-31T14:57:49.739Z
125 changes: 125 additions & 0 deletions ...teams/Add-a-user-to-a-team-returns-Represents-a-user-s-association-to-a-team-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions examples/v2/teams/CreateTeamMembership.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,26 @@
require "datadog_api_client"
api_instance = DatadogAPIClient::V2::TeamsAPI.new

# there is a valid "dd_team" in the system
DD_TEAM_DATA_ID = ENV["DD_TEAM_DATA_ID"]

# there is a valid "user" in the system
USER_DATA_ID = ENV["USER_DATA_ID"]

body = DatadogAPIClient::V2::UserTeamRequest.new({
data: DatadogAPIClient::V2::UserTeamCreate.new({
attributes: DatadogAPIClient::V2::UserTeamAttributes.new({
role: DatadogAPIClient::V2::UserTeamRole::ADMIN,
}),
relationships: DatadogAPIClient::V2::UserTeamRelationships.new({
team: DatadogAPIClient::V2::RelationshipToUserTeamTeam.new({
data: DatadogAPIClient::V2::RelationshipToUserTeamTeamData.new({
id: "d7e15d9d-d346-43da-81d8-3d9e71d9a5e9",
type: DatadogAPIClient::V2::UserTeamTeamType::TEAM,
}),
}),
user: DatadogAPIClient::V2::RelationshipToUserTeamUser.new({
data: DatadogAPIClient::V2::RelationshipToUserTeamUserData.new({
id: "b8626d7e-cedd-11eb-abf5-da7ad0900001",
id: USER_DATA_ID,
type: DatadogAPIClient::V2::UserTeamUserType::USERS,
}),
}),
}),
type: DatadogAPIClient::V2::UserTeamType::TEAM_MEMBERSHIPS,
}),
})
p api_instance.create_team_membership("team_id", body)
p api_instance.create_team_membership(DD_TEAM_DATA_ID, body)
19 changes: 13 additions & 6 deletions features/v2/teams.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,28 @@ Feature: Teams
When the request is sent
Then the response status is 204 Added

@generated @skip @team:DataDog/aaa-omg
@team:DataDog/aaa-omg
Scenario: Add a user to a team returns "API error response." response
Given new "CreateTeamMembership" request
And request contains "team_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"role": "admin"}, "relationships": {"team": {"data": {"id": "d7e15d9d-d346-43da-81d8-3d9e71d9a5e9", "type": "team"}}, "user": {"data": {"id": "b8626d7e-cedd-11eb-abf5-da7ad0900001", "type": "users"}}}, "type": "team_memberships"}}
And there is a valid "dd_team" in the system
And there is a valid "user" in the system
And there is a valid "team_membership" in the system
And request contains "team_id" parameter from "dd_team.data.id"
And body with value {"data": {"attributes": {"role": "admin"}, "relationships": {"user": {"data": {"id": "{{user.data.id}}", "type": "users"}}}, "type": "team_memberships"}}
When the request is sent
Then the response status is 409 API error response.

@generated @skip @team:DataDog/aaa-omg
@team:DataDog/aaa-omg
Scenario: Add a user to a team returns "Represents a user's association to a team" response
Given new "CreateTeamMembership" request
And request contains "team_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"role": "admin"}, "relationships": {"team": {"data": {"id": "d7e15d9d-d346-43da-81d8-3d9e71d9a5e9", "type": "team"}}, "user": {"data": {"id": "b8626d7e-cedd-11eb-abf5-da7ad0900001", "type": "users"}}}, "type": "team_memberships"}}
And there is a valid "dd_team" in the system
And there is a valid "user" in the system
And request contains "team_id" parameter from "dd_team.data.id"
And body with value {"data": {"attributes": {"role": "admin"}, "relationships": {"user": {"data": {"id": "{{user.data.id}}", "type": "users"}}}, "type": "team_memberships"}}
When the request is sent
Then the response status is 200 Represents a user's association to a team
And the response "data.attributes.role" is equal to "admin"
And the response "data.relationships.user.data.id" is equal to "{{ user.data.id }}"

@team:DataDog/aaa-omg
Scenario: Create a team hierarchy link returns "Conflict" response
Expand Down
Loading