Skip to content

fixing dependabot PR CI - #346

Merged
bm1549 merged 1 commit into
mainfrom
brian.marks/fix-dependabot-pr-ci
Jul 30, 2026
Merged

fixing dependabot PR CI#346
bm1549 merged 1 commit into
mainfrom
brian.marks/fix-dependabot-pr-ci

Conversation

@bm1549

@bm1549 bm1549 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

Skips Datadog test-report and coverage uploads when DD_CI_VIS_API_KEY is unavailable. Builds and tests still run, and JUnit uploads still run after a test failure when the key exists. The key itself is scoped to the upload steps.

Motivation

GitHub does not expose Actions secrets to Dependabot or fork pull requests, and reusable workflows may be called without inherited secrets. These runs were failing after successful builds and tests because upload steps ran with an empty key.

Additional Notes

Validated with actionlint and credential-condition checks.

Jira ticket: N/A

@bm1549 bm1549 added the AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos label Jul 30, 2026
@pr-commenter

pr-commenter Bot commented Jul 30, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-30 18:07:17

Comparing candidate commit 48ae01e in PR branch brian.marks/fix-dependabot-pr-ci with baseline commit 091059d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@bm1549 bm1549 changed the title fixing dependabot PR CI fix(ci): dependabot cannot upload to Datadog Jul 30, 2026
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 30, 2026

Copy link
Copy Markdown

Pipelines

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 91.75% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 48ae01e | Docs | Datadog PR Page | Give us feedback!

@bm1549 bm1549 changed the title fix(ci): dependabot cannot upload to Datadog fixing dependabot PR CI Jul 30, 2026
@bm1549
bm1549 marked this pull request as ready for review July 30, 2026 18:44
@bm1549
bm1549 requested review from a team as code owners July 30, 2026 18:44
@bm1549
bm1549 requested review from xlamorlette-datadog and removed request for a team July 30, 2026 18:44

@zacharycmontoya zacharycmontoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking into this!

@bm1549
bm1549 merged commit 45976fb into main Jul 30, 2026
66 of 68 checks passed
@bm1549
bm1549 deleted the brian.marks/fix-dependabot-pr-ci branch July 30, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants