Skip to content

Fix crash tracking initialization on Windows#10042

Closed
bmermet wants to merge 1 commit intomasterfrom
bmermet/fix-windows
Closed

Fix crash tracking initialization on Windows#10042
bmermet wants to merge 1 commit intomasterfrom
bmermet/fix-windows

Conversation

@bmermet
Copy link
Copy Markdown

@bmermet bmermet commented Nov 27, 2025

What Does This Do

This commit addresses UnsupportedOperationException errors when initializing crash tracking on Windows systems.

Motivation

Instrumenting a java app on Windows currently logs the following warnings:

[dd.trace 2025-11-27 09:52:09:269 +0000] [dd-task-scheduler] SEND_TELEMETRY datadog.crashtracking.Initializer - Unsupported permissions 'rwxrwxrwx' for C:\Users\Administrator\AppData\Local\Temp\ddprof_administrator\pid_488. Crash tracking will not work properly.
[dd.trace 2025-11-27 09:52:09:284 +0000] [dd-task-scheduler] SEND_TELEMETRY datadog.crashtracking.Initializer - Unexpected exception while initializing OOME notifier. OOMEs will not be tracked. [null] (Change the logging level to debug to see the full stacktrace)

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@bmermet bmermet added type: bug Bug report and fix comp: crash tracking Crash Tracking labels Nov 27, 2025
Copy link
Copy Markdown
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix — that recurring log message can definitely be annoying for Windows users. For future improvements, we should handle this scenario more gracefully on Windows, since we may still need to set read permissions for everyone.

Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 suggestion: ‏Rather than disabling the RO / RW set, I would implement the Windows related calls:

DosFileAttributeView view = Files.getFileAttributeView(path, DosFileAttributeView.class);
view.setReadOnly(true);

I know it's early to give feedback as it's a draft, but I saw it was already approved 😅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 1, 2026

This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it.

@github-actions github-actions Bot added the tag: stale Stale pull requests label Mar 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

This pull request has been closed because it has not had activity over the past quarter. Feel free to reopen the PR if you are still working on it.

@github-actions github-actions Bot closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: crash tracking Crash Tracking tag: stale Stale pull requests type: bug Bug report and fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants