Fix crash tracking initialization on Windows#10042
Conversation
amarziali
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix — that recurring log message can definitely be annoying for Windows users. For future improvements, we should handle this scenario more gracefully on Windows, since we may still need to set read permissions for everyone.
PerfectSlayer
left a comment
There was a problem hiding this comment.
🎯 suggestion: Rather than disabling the RO / RW set, I would implement the Windows related calls:
DosFileAttributeView view = Files.getFileAttributeView(path, DosFileAttributeView.class);
view.setReadOnly(true);I know it's early to give feedback as it's a draft, but I saw it was already approved 😅
|
This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it. |
|
This pull request has been closed because it has not had activity over the past quarter. Feel free to reopen the PR if you are still working on it. |
What Does This Do
This commit addresses UnsupportedOperationException errors when initializing crash tracking on Windows systems.
Motivation
Instrumenting a java app on Windows currently logs the following warnings:
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]