-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add support for AWS IAM login #22058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
| """OAuth callback that generates AWS MSK IAM authentication tokens.""" | ||
| try: | ||
| # Get AWS region from config or detect from environment | ||
| region = boto3.session.Session().region_name or 'us-east-1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be validated in config.py somehow instead? Defaulting to us-east-1 seems like it could cause subtle failures that are a headache to debug
What does this PR do?
Adds support for AWS MSK IAM authentication to the Kafka Consumer integration using SASL/OAUTHBEARER mechanism.
Motivation
Customers using Amazon MSK clusters with IAM authentication were unable to monitor their Kafka infrastructure with the Datadog Agent. Previously, they had to use SASL/SCRAM or mTLS authentication, which requires manual credential management.
This change enables monitoring AWS MSK clusters using IAM roles, providing:
Configuration:
instances:
security_protocol: SASL_SSL
sasl_mechanism: OAUTHBEARER
sasl_oauth_token_provider:
method: aws_msk_iamImplementation:
aws-msk-iam-sasl-signer-pythonto generate AWS IAM tokensconfluent-kafkaclientReview checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged