Don't set max_execution_time for MySQL 5.6 #22097
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethsamuel
added
qa/skip-qa
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
Contributor
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected * Fix with Cursor requires Datadog plugin ≥v2.17.0 🔗 Commit SHA: bf5b173 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
eric-weaver
reviewed
Dec 10, 2025
| with closing(self._check._mysql_metadata.get_db_connection().cursor(CommenterDictCursor)) as cursor: | ||
| query = self._get_tables_query() | ||
| max_execution_time = self._config.max_execution_time | ||
| if self._check.is_mariadb: |
Contributor
There was a problem hiding this comment.
For completeness can we add a version check for mariadb here as well. MAX_STATEMENT_TIME was added in 10.1.1 which is also quite old, but better to guard against potential issues here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skips setting the
max_execution_timewhen collecting schemas for MySQL 5.6.Motivation
max_execution_timeis not supported in MySQL 5.6.Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged