Skip to content

feat(ci): use feature branch if specified#7209

Open
MilanGarnier wants to merge 7 commits into
mainfrom
milan.garnier/php-checkout
Open

feat(ci): use feature branch if specified#7209
MilanGarnier wants to merge 7 commits into
mainfrom
milan.garnier/php-checkout

Conversation

@MilanGarnier

Copy link
Copy Markdown
Contributor

Motivation

Currently, system-tests run on the latest stable version of dd-trace-php. If a feature branch is specified in the PR title it is silently discarded. This PRs fetches the appropriate build on github's container registry.
In dd-trace-php, a new job publishes builds to the registry, with :branchname. (DataDog/dd-trace-php#4013)

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/scripts/load-binary.sh                                            @DataDog/system-tests-core

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 24, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 3 Pipeline jobs failed

Testing the test | System Tests (java, prod) / End-to-end #1 / play 1   View in Datadog   GitHub Actions

🧪 1 Test failed

All test failures are known flaky.

❄️ Known flaky: tests.integrations.test_inferred_proxy.Test_AWS_API_Gateway_Inferred_Span_Creation_v2.test_api_gateway_http_inferred_span_creation_optional_tags[play] from system_tests_suite   View in Datadog
ValueError: No span validates this test

self = <tests.integrations.test_inferred_proxy.Test_AWS_API_Gateway_Inferred_Span_Creation_v2 object at 0x7f0ef5c72cc0>

    def test_api_gateway_http_inferred_span_creation_optional_tags(self):
        assert self.r.text == "ok"
    
>       interfaces.library.validate_one_span(
            self.r,
            validator=mandatory_tags_validator_factory(
...

Not introduced in this PR.

Testing the test | System Tests (python, prod) / End-to-end #1 / uwsgi-poc 1   View in Datadog   GitHub Actions

🧪 1 Test failed

All test failures are known flaky.

❄️ Known flaky: tests.test_telemetry.Test_Telemetry.test_app_heartbeats_delays[uwsgi-poc] from system_tests_suite   View in Datadog
AssertionError: Heartbeat sent too fast: 1.1433275s. It should be sent every 2s
assert 1.1433275 > 1.5

self = <tests.test_telemetry.Test_Telemetry object at 0x7fa2401e2d50>

    @features.telemetry_heart_beat_collected
    def test_app_heartbeats_delays(self):
        """Check for telemetry heartbeat are not sent too fast/slow, regarding DD_TELEMETRY_HEARTBEAT_INTERVAL
        There are a lot of reason for individual heartbeats to be sent too slow/fast, and the subsequent ones
        to be sent too fast/slow so the RFC says that it must not drift. So we will check the average delay
...

Not introduced in this PR.

Testing the test | all-jobs-are-green   View in Datadog   GitHub Actions

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 65602f4 | Docs | Datadog PR Page | Give us feedback!

@MilanGarnier MilanGarnier changed the title feat(ci): use feature branch if specified feat(ci): use feature branch if specified [php@milan.garnier@publish-ci-builds] Jun 24, 2026
@MilanGarnier MilanGarnier changed the title feat(ci): use feature branch if specified [php@milan.garnier@publish-ci-builds] feat(ci): use feature branch if specified [php@milan.garnier/publish-ci-builds] Jun 24, 2026
@MilanGarnier MilanGarnier marked this pull request as ready for review June 30, 2026 12:10
@MilanGarnier MilanGarnier requested a review from a team as a code owner June 30, 2026 12:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 185ce0c1e7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread utils/scripts/load-binary.sh Outdated
Comment thread utils/scripts/load-binary.sh
@MilanGarnier MilanGarnier added enhancement New feature or request dev-x Improve developer experience labels Jun 30, 2026
MilanGarnier and others added 3 commits July 3, 2026 11:58
…MMIT_REF_SLUG

Without this, long branch names diverge from the tag dd-trace-php's
GitLab CI actually publishes, since GitLab truncates the slug.
@MilanGarnier MilanGarnier changed the title feat(ci): use feature branch if specified [php@milan.garnier/publish-ci-builds] feat(ci): use feature branch if specified Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-x Improve developer experience enhancement New feature or request mergequeue-status: removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants