fix(rust/parametric): report effective propagation style in /trace/config#7241
Draft
bm1549 wants to merge 1 commit into
Draft
fix(rust/parametric): report effective propagation style in /trace/config#7241bm1549 wants to merge 1 commit into
bm1549 wants to merge 1 commit into
Conversation
…nfig Mirror the library's effective-extractor resolution: use the extract-specific styles when set, otherwise fall back to the global propagation style (which is what OTEL_PROPAGATORS and a bare DD_TRACE_PROPAGATION_STYLE feed). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bm1549
added
the
ai-generated
Contributor
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 9f400e9 | Docs | Datadog PR Page | Give us feedback! |
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
to DataDog/dd-trace-rs
that referenced
this pull request
Jul 6, 2026
…271) # What does this PR do? Adds support for the OpenTelemetry `OTEL_PROPAGATORS` env var as a fallback for `DD_TRACE_PROPAGATION_STYLE`. When `DD_TRACE_PROPAGATION_STYLE` is unset, dd-trace-rs reads `OTEL_PROPAGATORS` and applies it to the global propagation style, matching the other Datadog tracers (Python, Go, Java, Node.js, .NET, Ruby, PHP). It reuses the existing `update_non_empty_string_with_fallback` helper (the one behind the `OTEL_SERVICE_NAME` alias), so only the global style is wired; extract/inject inherit it through the existing fallback in `propagation/config.rs`. Supported values: `datadog`, `tracecontext`, `baggage`, `b3` (single-header), `b3multi`, `none`. Unsupported OpenTelemetry propagators (`jaeger`, `xray`, `ottrace`) are dropped with a warning. `DD_TRACE_PROPAGATION_STYLE` wins when both are set. # Motivation Users who configure propagation via `OTEL_PROPAGATORS` expect dd-trace-rs to honor it the way the other tracers do. It was the only tracer (besides dd-trace-cpp) missing it. # Additional Notes - An empty `DD_TRACE_PROPAGATION_STYLE=""` is now treated as unset (falls back to `OTEL_PROPAGATORS`, then the default), consistent with the `OTEL_SERVICE_NAME` fallback. - Companion system-tests PR: DataDog/system-tests#7241. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: brian.marks <brian.marks@datadoghq.com>
Aaalibaba42
pushed a commit
to DataDog/dd-trace-rs
that referenced
this pull request
Jul 8, 2026
…271) # What does this PR do? Adds support for the OpenTelemetry `OTEL_PROPAGATORS` env var as a fallback for `DD_TRACE_PROPAGATION_STYLE`. When `DD_TRACE_PROPAGATION_STYLE` is unset, dd-trace-rs reads `OTEL_PROPAGATORS` and applies it to the global propagation style, matching the other Datadog tracers (Python, Go, Java, Node.js, .NET, Ruby, PHP). It reuses the existing `update_non_empty_string_with_fallback` helper (the one behind the `OTEL_SERVICE_NAME` alias), so only the global style is wired; extract/inject inherit it through the existing fallback in `propagation/config.rs`. Supported values: `datadog`, `tracecontext`, `baggage`, `b3` (single-header), `b3multi`, `none`. Unsupported OpenTelemetry propagators (`jaeger`, `xray`, `ottrace`) are dropped with a warning. `DD_TRACE_PROPAGATION_STYLE` wins when both are set. # Motivation Users who configure propagation via `OTEL_PROPAGATORS` expect dd-trace-rs to honor it the way the other tracers do. It was the only tracer (besides dd-trace-cpp) missing it. # Additional Notes - An empty `DD_TRACE_PROPAGATION_STYLE=""` is now treated as unset (falls back to `OTEL_PROPAGATORS`, then the default), consistent with the `OTEL_SERVICE_NAME` fallback. - Companion system-tests PR: DataDog/system-tests#7241. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: brian.marks <brian.marks@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Rust parametric app's
GET /trace/configreported the propagation style from the extract-specific config only, so a global-only style — including one fed byOTEL_PROPAGATORSor a bareDD_TRACE_PROPAGATION_STYLE— was reported as empty. This is the companion to DataDog/dd-trace-rs#271, which addsOTEL_PROPAGATORSsupport to dd-trace-rs.Changes
format_trace_propagation_extractin the Rust parametric app now falls back to the global propagation style when the extract-specific style is unset, mirroring the library's effective-extractor resolution (propagation/config.rs::get_extractors): extract-specific styles if set, otherwise the global style. One function, four added lines.Verified locally with
cargo checkagainst a linked dd-trace-rs source (the type signatures compose: both getters returnOption<&[TracePropagationStyle]>).Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present🤖 Generated with Claude Code